Skip to content

[core][docs] Clarify Ray Core walkthrough benchmark setup#64529

Open
kalyanamdewri wants to merge 1 commit into
ray-project:masterfrom
kalyanamdewri:docs/ray-core-walkthrough-init-note
Open

[core][docs] Clarify Ray Core walkthrough benchmark setup#64529
kalyanamdewri wants to merge 1 commit into
ray-project:masterfrom
kalyanamdewri:docs/ray-core-walkthrough-init-note

Conversation

@kalyanamdewri

Copy link
Copy Markdown

Summary:

Validation:

  • python3 -m json.tool doc/source/ray-core/examples/gentle_walkthrough.ipynb >/tmp/gentle_walkthrough.jsoncheck — passed
  • git diff --check — passed

Signed-off-by: kalyanamdewri <kalyanampriyam@gmail.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@kalyanamdewri kalyanamdewri marked this pull request as ready for review July 3, 2026 05:08
@kalyanamdewri kalyanamdewri requested review from a team as code owners July 3, 2026 05:08

Copy link
Copy Markdown
Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gentle_walkthrough.ipynb notebook to add a note explaining that ray.init() should be called before starting the timer if the benchmark code is copied into a separate script, ensuring task execution is measured instead of cluster startup. There are no review comments, so I have no feedback to provide.

@ray-gardener ray-gardener Bot added docs An issue or change related to documentation core Issues that should be addressed in Ray Core community-contribution Contributed by the community labels Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core docs An issue or change related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant