[core][docs] Clarify Ray Core walkthrough benchmark setup#64529
Open
kalyanamdewri wants to merge 1 commit into
Open
[core][docs] Clarify Ray Core walkthrough benchmark setup#64529kalyanamdewri wants to merge 1 commit into
kalyanamdewri wants to merge 1 commit into
Conversation
Signed-off-by: kalyanamdewri <kalyanampriyam@gmail.com>
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the gentle_walkthrough.ipynb notebook to add a note explaining that ray.init() should be called before starting the timer if the benchmark code is copied into a separate script, ensuring task execution is measured instead of cluster startup. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ray.init()before starting the timer.Validation:
python3 -m json.tool doc/source/ray-core/examples/gentle_walkthrough.ipynb >/tmp/gentle_walkthrough.jsoncheck— passedgit diff --check— passed