Fix the numpy ndarray subclass serialization bug #7392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Test PASSed. |
2 tasks
| if (self.proto < 5 or | ||
| (not obj.flags.c_contiguous and | ||
| not obj.flags.f_contiguous) or | ||
| (not obj.flags.c_contiguous and not obj.flags.f_contiguous) or |
Collaborator
There was a problem hiding this comment.
@suquark are these fixes being upstreamed to cloudpickle?
Member
Author
There was a problem hiding this comment.
There has been dramatic changes to the upstream (e.g. drop of python2 support). We definitely need to sync with them first. I'll create a PR later to sync with the upstream, then we could try to update changes to the upstream.
pcmoritz
approved these changes
Mar 2, 2020
|
Test FAILed. |
ffbin
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #7376
Checks
scripts/format.shto lint the changes in this PR.