[raycicmd] Resolve group-level depends_on through array expansion

[andrew-anyscale]

Group-level depends_on is how separate .rayci.yml files declare cross-group dependencies. When such a reference points to an array step, the base key was passed through unchanged to the Buildkite pipeline, causing "Unresolved group step dependencies" errors because the base key no longer exists after expansion.

For example, given these pipeline files:

.buildkite/_wheel-build.rayci.yml:

group: wheel build
steps:
  - name: ray-core-build
    label: "wanda: core binary parts py{{array.python}} (x86_64)"
    wanda: ci/docker/ray-core.wanda.yaml
    array:
      python: ["3.10", "3.11", "3.12"]

.buildkite/core.rayci.yml:

group: core tests
depends_on:
  - forge
  - ray-core-build
steps:
  - key: test-step
    commands: ["echo test"]

After array expansion, "ray-core-build" becomes three steps (ray-core-build--python310, etc.) but the group depends_on in core.rayci.yml still referenced the non-existent base key "ray-core-build".

Fix: add a third pass in expandArraySteps that fans out group-level DependsOn references to array steps into their expanded keys, matching the existing behavior for step-level depends_on.

The regression test covers the cross-group case: an array step defined in one group referenced by another group's depends_on, mirroring the separate .rayci.yml file scenario.

Topic: fix-array-group-depends-on

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com

[andrew-anyscale]

Reviews in this chain:
└#465 [raycicmd] Resolve group-level depends_on through array expansion

[andrew-anyscale]

#	head	base	diff	date	summary
0	72b9ccba	dd702afd	diff	Mar 19 8:25 AM	2 files changed, 102 insertions(+)
1	469b08ba	dd702afd	diff	Mar 19 8:27 AM	0 files changed
2	d4fefa87	dd702afd	diff	Mar 19 8:31 AM	0 files changed
3	a21001e8	dd702afd	diff	Mar 19 8:33 AM	1 file changed, 1 insertion(+), 1 deletion(-)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where group-level dependencies on array-expanded steps were not correctly resolved in the Buildkite pipeline, leading to failures. The changes introduce a new processing pass to ensure that these dependencies are properly fanned out to their individual expanded keys, aligning group behavior with existing step-level dependency resolution. This enhancement improves the robustness and reliability of pipeline configurations utilizing array expansion.

Highlights

• Group-level DependsOn Resolution: Implemented a third pass in expandArraySteps to correctly resolve group-level depends_on references that point to array steps. This fans out the base array key into its expanded keys, preventing 'Unresolved group step dependencies' errors.
• New Test Cases: Added two new test cases, TestExpandArraySteps_GroupDependsOnArrayStep and TestExpandArraySteps_GroupDependsOnNonArrayStep, to validate the correct expansion of group-level dependencies for both array and non-array steps.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly resolves an issue where group-level depends_on was not being expanded for array steps. The added third pass in expandArraySteps effectively handles this expansion. The new tests adequately cover the fix for both array and non-array step dependencies. I've added a few suggestions to improve code efficiency and test readability.