Skip to content

[raycicmd] Expand array selectors in group-level depends_on#475

Merged
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/fix-group-deps-star
Apr 1, 2026
Merged

[raycicmd] Expand array selectors in group-level depends_on#475
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/fix-group-deps-star

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

Group-level depends_on entries that reference array steps were not being expanded. A selector like build-step(*) passed through raw to Buildkite, which rejected it because parentheses are not valid in step key references.

Apply the same selector parsing used for step-level depends_on:

  • (*) expands to all array variants
  • (key=val) filters to matching variants
  • ($) is rejected with a clear error (groups have no current
    array element for implicit dimension matching)
  • Bare references to array steps expand to all variants

Topic: fix-group-deps-star
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

Reviews in this chain:
#475 [raycicmd] Expand array selectors in group-level depends_on

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Mar 30, 2026

# head base diff date summary
0 3cf17626 ec4c235a diff Mar 30 11:48 AM 3 files changed, 144 insertions(+), 11 deletions(-)
1 8bc1aebd ec4c235a diff Mar 30 12:58 PM 2 files changed, 56 insertions(+), 74 deletions(-)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for array selector syntax, such as '(*)' and '(key=val)', to group-level 'depends_on' entries by introducing a new 'resolveGroupDependsOn' function. The reviewer recommended optimizing the 'result' slice allocation in this new function for better performance and suggested refactoring the newly added tests into a table-driven format to improve maintainability and reduce code duplication.

Comment thread raycicmd/array_depends.go Outdated
Comment thread raycicmd/array_expand_test.go
Group-level depends_on entries that reference array steps were not being expanded.  A selector like `build-step(*)` passed through raw to Buildkite, which rejected it because parentheses are not valid in step key references.

Apply the same selector parsing used for step-level depends_on:
- (*) expands to all array variants
- (key=val) filters to matching variants
- ($) is rejected with a clear error (groups have no current
  array element for implicit dimension matching)
- Bare references to array steps expand to all variants

Topic: fix-group-deps-star
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/fix-group-deps-star branch from 3cf1762 to 8bc1aeb Compare March 30, 2026 19:58
@andrew-anyscale andrew-anyscale enabled auto-merge (squash) April 1, 2026 14:39
@andrew-anyscale andrew-anyscale disabled auto-merge April 1, 2026 15:13
@andrew-anyscale andrew-anyscale merged commit 2d4c509 into main Apr 1, 2026
2 checks passed
@andrew-anyscale andrew-anyscale deleted the andrew/revup/main/fix-group-deps-star branch April 1, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants