[raycicmd] Expand array selectors in group-level depends_on#475
Merged
andrew-anyscale merged 1 commit intomainfrom Apr 1, 2026
Merged
[raycicmd] Expand array selectors in group-level depends_on#475andrew-anyscale merged 1 commit intomainfrom
andrew-anyscale merged 1 commit intomainfrom
Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for array selector syntax, such as '(*)' and '(key=val)', to group-level 'depends_on' entries by introducing a new 'resolveGroupDependsOn' function. The reviewer recommended optimizing the 'result' slice allocation in this new function for better performance and suggested refactoring the newly added tests into a table-driven format to improve maintainability and reduce code duplication.
Group-level depends_on entries that reference array steps were not being expanded. A selector like `build-step(*)` passed through raw to Buildkite, which rejected it because parentheses are not valid in step key references. Apply the same selector parsing used for step-level depends_on: - (*) expands to all array variants - (key=val) filters to matching variants - ($) is rejected with a clear error (groups have no current array element for implicit dimension matching) - Bare references to array steps expand to all variants Topic: fix-group-deps-star Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
3cf1762 to
8bc1aeb
Compare
aslonnie
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group-level depends_on entries that reference array steps were not being expanded. A selector like
build-step(*)passed through raw to Buildkite, which rejected it because parentheses are not valid in step key references.Apply the same selector parsing used for step-level depends_on:
array element for implicit dimension matching)
Topic: fix-group-deps-star
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com