[wanda] Handle scratch as a built-in FROM image#485
Merged
andrew-anyscale merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the "scratch" base image, allowing it to be used as an optional dependency via environment variables. The changes include logic in the forge to bypass remote resolution for "scratch" and new test cases to verify this behavior. A review comment suggests using case-insensitive comparison for the "scratch" keyword to better align with Docker's behavior.
andrew-anyscale
force-pushed
the
andrew/revup/main/optional-wanda
branch
from
5049396 to
4ba74c5
Compare
When a wanda spec uses "scratch" in froms (e.g. via an env var set to "scratch" to disable an optional dependency), wanda tried to pull it from Docker Hub as a remote image. Since scratch is a Docker built-in pseudo-image that doesn't exist in any registry, the pull failed with MANIFEST_UNKNOWN. https://buildkite.com/ray-project/premerge/builds/64091/steps/canvas?sid=019d7849-3605-4a37-9aab-bcb3255fe01f&tab=output#019d7859-6aed-462c-9475-b44b312c9a7b/L176 Skip remote resolution for scratch and treat it as an already-available local image, matching Docker's own handling of FROM scratch. Topic: optional-wanda Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
andrew-anyscale
force-pushed
the
andrew/revup/main/optional-wanda
branch
from
4ba74c5 to
60ee70a
Compare
Contributor
Author
aslonnie
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a wanda spec uses "scratch" in froms (e.g. via an env var set to "scratch" to disable an optional dependency), wanda tried to pull it from Docker Hub as a remote image. Since scratch is a Docker built-in pseudo-image that doesn't exist in any registry, the pull failed with MANIFEST_UNKNOWN.
https://buildkite.com/ray-project/premerge/builds/64091/steps/canvas?sid=019d7849-3605-4a37-9aab-bcb3255fe01f&tab=output#019d7859-6aed-462c-9475-b44b312c9a7b/L176
Skip remote resolution for scratch and treat it as an already-available local image, matching Docker's own handling of FROM scratch.
Topic: optional-wanda
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com