[raydp-332] Fix security issue of protobuf < 3.19.5#333
Merged
kira-lin merged 1 commit intoray-project:masterfrom Apr 23, 2023
Merged
[raydp-332] Fix security issue of protobuf < 3.19.5#333kira-lin merged 1 commit intoray-project:masterfrom
kira-lin merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: jiafu zhang <jiafu.zhang@intel.com>
Contributor
Author
|
@carsonwang as tested with ray 2.1 - 2.3, it worked though there is a warning like below, |
Collaborator
|
Is grpcio-tools used in our MPI test? Maybe we should downgrade its version as well? |
Contributor
Author
|
Contributor
Author
|
@kira-lin @carsonwang do you have more comments? |
Collaborator
|
LGTM |
Collaborator
|
Ray's requirement for protobuf is "protobuf >= 3.15.3, != 3.19.5", why are we limiting it <=3.20.3? |
Contributor
Author
It's due to grpcio-tools install protobuf-4.22.* which doesn't work well with raydp. |
Collaborator
|
Thanks, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a security issue report, https://github.com/oap-project/raydp/security/dependabot/6.
To fix it, we limit protobuf > 3.19.5 and <= 3.20.3