Skip to content

Conversation

@j3lte
Copy link
Contributor

@j3lte j3lte commented Dec 15, 2025

Description

  • Added Windows support
  • Update (dev) dependencies
  • Refactor code (typo's, ts/tsx naming)

Screencast

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: nasa Issues related to the nasa extension platform: macOS platform: Windows labels Dec 15, 2025
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @mSarheed you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 15, 2025

Greptile Overview

Greptile Summary

This PR refactors the NASA extension with improved code organization and adds Windows platform support. The changes include fixing typos in folder names (componenetscomponents, prefrencespreferences), consolidating type definitions into a single index.ts file, implementing TypeScript path aliases (@/*) for cleaner imports, updating dependencies to latest versions, and migrating from legacy ESLint config to the new flat config format.

Key improvements:

  • Fixed multiple typos in folder and file names
  • Consolidated all type definitions into src/types/index.ts for better organization
  • Added TypeScript path aliases to simplify import statements throughout the codebase
  • Updated @raycast/api from ^1.81.2 to ^1.103.10 and @raycast/utils from ^1.17.0 to ^2.2.2
  • Migrated to ESLint flat config format (eslint.config.js) following Raycast's standard template
  • Added Windows platform support in package.json
  • Added @j3lte as a contributor

Confidence Score: 5/5

  • This PR is safe to merge with no concerns
  • This is a well-executed refactoring PR that improves code organization without changing functionality. All changes are straightforward: fixing typos in folder/file names, consolidating types, adding path aliases, updating dependencies, and following Raycast's ESLint template. The changelog entry correctly uses the {PR_MERGE_DATE} template. No logic changes, no breaking changes, and all imports have been properly updated.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
extensions/nasa/CHANGELOG.md 5/5 Added new changelog entry with correct {PR_MERGE_DATE} template format
extensions/nasa/package.json 5/5 Added Windows platform support, updated dependencies, and added contributor
extensions/nasa/eslint.config.js 5/5 Migrated to new ESLint flat config format following Raycast template
extensions/nasa/tsconfig.json 5/5 Added TypeScript path aliases for cleaner imports using @/* pattern
extensions/nasa/src/types/index.ts 5/5 Consolidated all type definitions into single index file for better organization
extensions/nasa/src/constants/preferences.ts 5/5 Renamed from prefrences.tsx to preferences.ts, fixing typo in filename

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@raycast-extensions-bot raycast-extensions-bot bot added the Approved Approved by a user label Dec 15, 2025
@pernielsentikaer pernielsentikaer removed the Approved Approved by a user label Dec 16, 2025
@pernielsentikaer pernielsentikaer self-assigned this Dec 17, 2025
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 9a1c8da into raycast:main Dec 17, 2025
3 checks passed
@github-actions
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/mSarheed/nasa

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@j3lte j3lte deleted the ext/nasa branch December 17, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: nasa Issues related to the nasa extension platform: macOS platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants