Open
Conversation
- fix: lint fix - fix: fix auth erro consistency
Collaborator
|
Thank you for your contribution! 🎉 🔔 @raunofreiberg @peduarte @xmok you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="ext/bmrks"
FORK_URL="https://github.com/almoce/raycast-extensions.git"
EXTENSION_NAME="bmrks"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Contributor
Greptile SummaryThis PR improves the bmrks extension by making auth error handling more robust and preventing duplicate bookmark submissions. The changes switch from brittle string matching to structured error code checking for authentication errors, and add proper state management to prevent race conditions during form submission. Key improvements:
Missing requirement:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 3f5f9a8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves reliability and UX in the bmrks extension by fixing auth error handling and preventing
duplicate bookmark submissions.
Changes
isSubmitting).
Why