Update zotero extension#26942
Conversation
|
Thank you for your contribution! 🎉 🔔 @sadanand-singh @lazarjov @joshuahhh @faridrashidi you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="zotero"
FORK_URL="https://github.com/ridemountainpig/extensions.git"
EXTENSION_NAME="zotero"
REPO_NAME="extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR adds an "Open PDF in System Viewer" action to the Zotero extension, allowing users to open PDF attachments with the macOS system's default viewer instead of routing everything through Zotero. A new
Confidence Score: 5/5Safe to merge — all prior P1 concerns resolved; one minor P2 action-ordering note remains that does not affect functionality All three previously-raised P1 concerns have been fully addressed: resolveHome is reused from zoteroApi.ts instead of duplicated, open() has error handling with showHUD, and attachmentFilePath is computed once per item and reused. The only remaining finding is a P2 style note about action panel ordering which does not impact correctness, user data, or the primary use case. No files require special attention Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: extensions/zotero/src/common/View.tsx
Line: 263-278
Comment:
**New action inserted mid-list instead of appended to the end**
Per the extension guidelines, new action panel actions should be appended to the end of the list rather than inserted in the middle. The "Open PDF in System Viewer" action is currently placed as the second action (right after "Open PDF"), before "Open in Zotero" and all the other existing actions.
Consider moving it to just before the `ActionPanel.Section` block so the established action order isn't disrupted and users aren't surprised by keyboard-shortcut shifts on existing actions.
**Rule Used:** What: New action panel actions should be appended ... ([source](https://app.greptile.com/review/custom-context?memory=cde63d3f-214c-4294-9a2a-bb8323ef7d33))
How can I resolve this? If you propose a fix, please make it concise.Greploops — Automatically fix all review issues by running Reviews (2): Last reviewed commit: "Update zotero extension" | Re-trigger Greptile |
|
@greptile-apps please review again. |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Add "Open PDF in System Viewer" action to open the attachment with the system's default viewer. Close #26817.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool