Update zeabur extension#27150
Conversation
|
Thank you for the update! 🎉 We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR fixes null-safety issues across the Zeabur extension: Confidence Score: 5/5Safe to merge — all findings are minor style/type suggestions with no blocking correctness issues. All changes are targeted null-safety fixes that address real crash scenarios. The two P2 comments cover a redundant optional chain and a type-level concern about undefined leaking into a string prop, both of which are unlikely to cause observable runtime problems in practice. No files require special attention. Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: extensions/zeabur/src/manage-projects.tsx
Line: 116
Comment:
**Redundant optional chaining inside guarded branch**
The outer spread condition already checks `project.region.providerInfo?.code` for truthiness, so by the time this line executes `providerInfo` is guaranteed to be non-null and `code` is truthy. The inner `?.` is redundant.
```suggestion
tag: project.region.providerInfo.code,
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: extensions/zeabur/src/manage-projects.tsx
Line: 143
Comment:
**`undefined` environmentID leaks into `ProjectServices`**
When `project.environments` is empty, `project.environments[0]?._id` evaluates to `undefined`, but `ProjectServicesProps.environmentID` is typed as `string`. The same pattern exists in `manage-servers.tsx` line 126. At runtime this passes `undefined` into every downstream GraphQL call that uses `environmentID`, which would silently produce bad requests rather than crashing visibly.
A safer approach would be to render nothing (or show a toast) when there's no environment:
```suggestion
target={project.environments[0] ? <ProjectServices projectID={project._id} environmentID={project.environments[0]._id} /> : undefined}
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Update zeabur extension" | Re-trigger Greptile |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool