Skip to content

Update desktoprenamer extension#27936

Merged
raycastbot merged 8 commits into
raycast:mainfrom
gitmichaelqiu:ext/desktoprenamer
May 17, 2026
Merged

Update desktoprenamer extension#27936
raycastbot merged 8 commits into
raycast:mainfrom
gitmichaelqiu:ext/desktoprenamer

Conversation

@gitmichaelqiu

@gitmichaelqiu gitmichaelqiu commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description

Screencast

Checklist

- Merge branch \'contributions/merge-1778860870440\'
- Pull contributions
- style: improve code styles
- chore: revert background sync for toggle commands
- feat: background refresh for toggle command subtitles
- feat: display actual toggle status in Raycast command subtitle
- fix: use valid \'return\' key for shortcut in Batch Move
- fix: consistent primary action in Batch Move
- feat: return-to-space preference and Batch Move UI redesign
- feat: add Batch Move Windows command
- perf: optimize switch and move window speed
- fix: use conservative move window approach
- fix: pass from space parameter in move window commands
- feat: add move window actions and desktop filter to List Windows
- feat: add List Windows command
- chore(env): update package-lock.json
- fix: show clean Not Running toast instead of raw "NotRunning"
- fix: show clean SpaceAPI Disabled toast instead of raw AppleScript error
- fix: use full tell block for reload space labels command
- fix: surface actual AppleScript error message in toast
- feat: use native reload space labels command
- fix: use label toggle workaround for Reload Space Labels
- feat: add Reload Space Labels command
- feat: add Cmd+R rename support to Move Window command
- feat: add Cmd+Enter move window shortcut to Switch Desktop
- feat: add Move Window command
- fix: remove deprecated toggle-space-label-windows command
- Sanitize ID
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: desktoprenamer Issues related to the desktoprenamer extension platform: macOS OP is author The OP of the PR is the author of the extension labels May 15, 2026
@raycastbot

Copy link
Copy Markdown
Collaborator

Thank you for the update! 🎉

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days.

- Fix TypeScript errors in Batch Move and List Windows commands
- fix: remove redundant toggle menubar items command
- docs: update CHANGELOG.md
@gitmichaelqiu

Copy link
Copy Markdown
Contributor Author

Change log:

  • Added Move Window command
  • Added List Windows command
  • Added Batch Move Windows command
  • Added Reload Space Labels command
  • Added Move Window actions to Switch Desktop command
  • Removed Toggle Space Label Window command

@gitmichaelqiu gitmichaelqiu marked this pull request as ready for review May 16, 2026 09:38
@greptile-apps

greptile-apps Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This update extends the desktoprenamer extension with four new commands (List Windows, Move Window, Batch Move Windows, Reload Space Labels) and removes the previously existing Toggle Space Label Window command. The Switch Desktop command gains a secondary Move Window action as well.

  • The previously reported empty-string guards on split(",") results in list-windows.tsx and batch-move-windows.tsx have been correctly addressed using if (!currentIds[0]) / if (currentIds[0]).
  • Both files now use getPreferenceValues<Preferences>() without a hand-rolled interface, resolving the earlier type-maintenance concern.
  • toggle-menubar-item.ts and toggle-space-label-windows.ts are deleted; no orphaned command entries remain in package.json.

Confidence Score: 5/5

Safe to merge — the new commands are self-contained AppleScript wrappers with proper error handling, and the logic fixes from the previous round have been applied correctly.

All functional paths in the new commands look correct: the split-guard fixes from the previous review are in place, preference values use the auto-generated type, and deleted files have corresponding command entries removed from package.json. No new runtime errors or data-loss paths were found.

No files require special attention.

Important Files Changed

Filename Overview
extensions/desktoprenamer/src/list-windows.tsx New command listing all windows grouped by space with switch/move actions; previously flagged split-guard bugs fixed at lines 98 and 138.
extensions/desktoprenamer/src/batch-move-windows.tsx New command for staging and executing bulk window moves across desktops; correctly guards the split-result check and restores original space via preference.
extensions/desktoprenamer/src/move-window.tsx New command to move the active window to a chosen desktop; clean and minimal.
extensions/desktoprenamer/src/switch-to-desktop.tsx Extends the existing Switch Desktop command with a secondary Move Window action alongside the rename shortcut.
extensions/desktoprenamer/src/reload-labels.ts New no-view command that triggers a label reload via AppleScript and shows a HUD confirmation.
extensions/desktoprenamer/package.json Adds four new view/no-view commands and a single checkbox preference; schema, platforms, and categories are all valid.
extensions/desktoprenamer/CHANGELOG.md New entry added at the top for the new commands; uses a hardcoded date instead of the required {PR_MERGE_DATE} placeholder (previously flagged).
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
extensions/desktoprenamer/src/list-windows.tsx:163-167
The `delay` helper is defined as a nested function inside the component, so a new function object is allocated on every render. It has no closure over any component state, making it a pure utility — moving it to module scope (or into `utils.ts` alongside the other helpers) would be the idiomatic approach and consistent with how `batch-move-windows.tsx` already hoists it outside the component.

```suggestion
  return (
```

Reviews (5): Last reviewed commit: "Update CHANGELOG.md" | Re-trigger Greptile

Comment thread extensions/desktoprenamer/CHANGELOG.md Outdated
Comment thread extensions/desktoprenamer/src/list-windows.tsx Outdated
Comment thread extensions/desktoprenamer/src/list-windows.tsx
@gitmichaelqiu gitmichaelqiu marked this pull request as draft May 16, 2026 09:44
- fix(list-windows): fix dead empty-string guard for current space id
- refactor: use auto-generated Preferences type in getPreferenceValues
- chore: use PR_MERGE_DATE placeholder in changelog
@gitmichaelqiu gitmichaelqiu marked this pull request as ready for review May 17, 2026 15:19
- chore: add eslint.config.js for ESLint v9 flat config compatibility
- style: improve code styles
- refactor: extract duplicate space fetching and RenameSpaceForm to shared module
- fix(batch-move): avoid double error toast on failure
Comment thread extensions/desktoprenamer/src/list-windows.tsx
- fix: correct empty-string check in returnToOriginalSpace check
- refactor: use defineConfig in eslint.config.js for flat config normalization
@0xdhrv 0xdhrv self-assigned this May 17, 2026

@0xdhrv 0xdhrv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved ✅

@raycastbot raycastbot merged commit 2dad2ff into raycast:main May 17, 2026
1 check passed
@github-actions

Copy link
Copy Markdown
Contributor

Published to the Raycast Store:
https://raycast.com/michael_qiu/desktoprenamer

@raycastbot

Copy link
Copy Markdown
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@gitmichaelqiu gitmichaelqiu deleted the ext/desktoprenamer branch June 25, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: desktoprenamer Issues related to the desktoprenamer extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants