[Jira] Fix attachment image URLs in issue details#28069
Conversation
|
Thank you for your contribution! 🎉 🔔 @thomaslombart @FezVrasta @teziovsky @gavinroderick @michael-par @literallyjustroy @mheidinger @luarmr @horumyy @rsperezn @Silv-1 @EyLuismi @pernielsentikaer @BehnH @JokeyChen @Murreey @erayack @0xdhrv @dytsou you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="fix/27521-jira-attachment-content-url"
FORK_URL="https://github.com/mturac/extensions.git"
EXTENSION_NAME="jira"
REPO_NAME="extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR fixes Jira issue details failing to load when a description contains absolute attachment image URLs by introducing
Confidence Score: 4/5The core fix is sound for the common cases, but the OAuth proxy rewriting only covers /rest/ paths, leaving attachment thumbnail URLs on tenant domains unrouted — a gap already flagged in prior review threads that remains unaddressed. The host-allowlist correctly stops bearer tokens from leaking to non-Atlassian domains. However, in OAuth mode, absolute tenant URLs whose paths don't start with /rest/ (e.g. /secure/thumbnail/…) fall through to return uri and are sent directly to the tenant domain rather than the api.atlassian.com proxy, where they will fail with a 401. This gap was raised in a previous review thread and is still present in the merged code. extensions/jira/src/components/IssueDetail.tsx — the resolveAuthenticatedImageUri function's OAuth proxy branch only rewrites /rest/ paths, leaving /secure/ attachment URLs unhandled. Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
extensions/jira/CHANGELOG.md:3-7
The new changelog entry uses a hardcoded date instead of the `{PR_MERGE_DATE}` placeholder required by the project convention. The merge date should be populated automatically at merge time, not set manually.
```suggestion
## [Bug Fix] - {PR_MERGE_DATE}
- Fixed issue details failing to load when descriptions include absolute Jira attachment image URLs
## [Bug Fix] - 2026-05-18
```
Reviews (6): Last reviewed commit: "Update CHANGELOG.md" | Re-trigger Greptile |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@mturac). Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag. |
Summary
Validation