-
Notifications
You must be signed in to change notification settings - Fork 948
Add: prayer-summary for dynamic prayer times #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
unnamedd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mianmuneebajaz, thanks for your contribution to our repository.
When I was reviewing it, I realized that perhaps you do not want to have it as a Script Command but as an Extension, and there are a few reasons for that. In the end, I have a feeling you are going to agree with me.
Few Cons for Script Command
- Script Commands are not an easy thing to install; it demands some knowledge.
- Your Script Command requires a few extra tools to be installed in order to make it work properly, and again, forcing the user to install them themselves.
- Making it a template will require your user to change some configurations before use.
- It will run in the root search of Raycast.
Few Pros for Extension
- Easier to install and distribute
- You will have far more tools to help in the request and information parsing (where you are currently using
jqfor that) - Easier way to configure it
- It can run directly in the macOS menu bar, making it visible 100% of the time if the user prefers
- A huge documentation and examples of how to create an extension yourself.
With all that being said, I guess it would be amazing to have it as an Extension.
What do you think?
|
Hi @unnamedd, thank you for the detailed review and suggestions! I've made all the requested changes:
Regarding the Extension suggestion: However, I'd like to note that this Script Command is intended as an improved, configurable version of the existing commands/culture/prayer-times.sh that's already in the repository. The key differences from that command are:
Since we already have a prayer times script command in the repo, I thought this would be a nice addition as an alternative variant. |
unnamedd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks awesome to me! Thanks a lot!
The idea of implementing it as an extension is just an idea, would be very amazing if you could make it with different UI components, more configurable, but again, it is completely up to you. It is very very funny writing extensions for Raycast.
nhojb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contribution!
Description
This PR adds a new script command called "Prayer Summary".
It allows a user to instantly view Islamic prayer times for their location directly in Raycast's menu bar.
The command shows:
Key features:
Type of change
Screenshot
Dependencies / Requirements
Checklist