Merged
Conversation
Add book-style documentation covering chain setup, validator management, follower nodes, contract deployment, transactions, load testing, configuration reference, monitoring, troubleshooting, and architecture. Build with: make book Closes #3
pedro-lino
requested changes
Mar 19, 2026
Collaborator
pedro-lino
left a comment
There was a problem hiding this comment.
Thanks for the update, left some comments please check them out.
- Fix quorum formula to match code: (2n - 1) / 3 + 1 - Fix proposer election description to match actual rotation logic - Fix docker push target: docker-tag-registry, not docker-push - Remove incorrect reference to non-existent QBFTErc20 contract
pedro-lino
approved these changes
Mar 20, 2026
Collaborator
pedro-lino
left a comment
There was a problem hiding this comment.
Nice, thanks for the adjustments!
Collaborator
|
That looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make booktarget for building the docstarget/book/(already gitignored)Documentation structure
Closes #3