Skip to content

Conversation

@Grannath
Copy link
Collaborator

The newest version of Gradle broke parts of the current build. Some deprecated features were also still in use. This PR tries to fix some of those.

Importing and applying scripts directly has been discouraged for a while. The same is true for using a subprojects block to share configuration. The recommended way to do this are convention plugins.

It is straightforward for the most part to convert the existing scripts to convention plugins. The contents of the subprojects block can also be applied in a convention plugin.

To make fixing the remaining issues easier, and help in future development, the convention plugins are then converted to Kotlin. The code completion and better typing help find and fix issues.

Some small simplifications have been made, where a direct API is available instead of workarounds. A bigger change of this kind is changing dependencies from implementation to api directly instead of rewriting their scope later directly in the Maven POM.

The newest version of Gradle broke parts of the current build. Some
deprecated features were also still in use. This PR tries to fix some
of those.

Importing and applying scripts directly has been discouraged for a
while. The same is true for using a `subprojects` block to share
configuration. The recommended way to do this are convention plugins.

It is straightforward for the most part to convert the existing
scripts to convention plugins. The contents of the `subprojects` block
can also be applied in a convention plugin.

To make fixing the remaining issues easier, and help in future
development, the convention plugins are then converted to Kotlin. The
code completion and better typing help find and fix issues.

Some small simplifications have been made, where a direct API is
available instead of workarounds. A bigger change of this kind is
changing dependencies from `implementation` to `api` directly instead
of rewriting their scope later directly in the Maven POM.
@Grannath Grannath requested a review from raynigon August 13, 2024 09:02
@github-actions github-actions bot added the feature New feature or request label Aug 13, 2024
Copy link
Owner

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raynigon raynigon merged commit 0eacb11 into main Aug 13, 2024
@raynigon raynigon deleted the feature/upgrade-gradle-build branch August 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants