fix: dropdown in breadcrumb and table #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the dropdown behavior of the breadcrumb and data table filter components by updating event handlers and standardizing code formatting.
- Updated DropdownMenu event handlers to use onClick instead of onSelect.
- Standardized import quoting and arrow function formatting for consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/raystack/v1/components/data-table/components/filters.tsx | Updated dropdown event handler and refactored arrow function syntax in filter components. |
| packages/raystack/v1/components/breadcrumb/breadcrumb.tsx | Applied consistent formatting and updated dropdown item event handling in breadcrumb component. |
Comments suppressed due to low confidence (2)
packages/raystack/v1/components/breadcrumb/breadcrumb.tsx:88
- Verify that replacing onSelect with onClick in the DropdownMenu.Item is consistent with the component's updated API usage.
<DropdownMenu.Item key={dropdownIndex} className={styles['breadcrumb-dropdown-item']} onClick={() => onItemClick && onItemClick({ label: dropdownItem.label, href: dropdownItem.href })}>
packages/raystack/v1/components/data-table/components/filters.tsx:45
- Confirm that switching from onSelect to onClick aligns with the updated DropdownMenu API; if not, adjust the event handler accordingly.
<DropdownMenu.Item key={id} onClick={() => onAddFilter(column)}>
rohilsurana
added a commit
that referenced
this pull request
Jun 9, 2025
* feat: Dropdown 2.0 (#367) * wip: dropdown changes * feat: migrate to ariakit dropdown menu * fix: update dropdown doc * feat: dropdown autocomplete support * fix: dropdown focus loop * feat: dropdown examples * fix: remove redundant prop * feat: update dropdown docs * feat: update dropdown docs * feat: update linear demo * chore: update pnpm lock * chore: update lockfile * fix: ci breaking as checkout position incorrect (#391) (#400) * fix: ci breaking as checkout position incorrect (#391) * fix: update version in package.json (#394) * fix: update version in package.json * fix: add ref --------- Co-authored-by: Gaurav Singh <gaurav3017@gmail.com> * ci: create release file for rc tags (#401) * fix: update tag regex in github action (#403) * ci: add npm dist tags to the package (#405) * feat: add `autocomplete` support for Select (#395) * feat: autocomplete functionality in select * feat: select autocomplete qol changes * feat: update select docs * feat: update select doc tag * feat: add support for htmlAutocomplete * feat: select improvements (#397) * feat: autocomplete functionality in select * feat: select autocomplete qol changes * feat: update select docs * feat: update select doc tag * feat: add support for htmlAutocomplete * feat: select updates * feat: update docs * fix: use rs space tokens * chore: merge main into develop (#408) * Feat: Add Skeleton component (#381) * feat(calendar): handle loading state (#382) * feat(calendar): handle loading state * chore: minor refactor * fix: ci breaking as checkout position incorrect (#391) * Revert/workflow 4573 (#392) * fix (CI): Workflow breaking (#393) fix: update release workflow to enforce branch and tag rules * fix: update version in package.json (#394) * fix: update version in package.json * fix: add ref * feat: Support for `as` in Sidebar.Item (#386) * feat: as support for sidebar item * feat: update props in doc * Feat: Setup Code formatting, linting and import sorter (#384) * feat: grid component (#383) * feat: grid component * feat: grid doc * fix: Error prop not overriding for date-picker (#398) * Fix release files tag main (#404) * ci: create release file for rc tags * fix: update tag regex in github action * fix: Error prop not overriding for date-picker (#402) * fix: Error prop not overriding for date-picker * fix: Error prop not overriding for date-picker --------- Co-authored-by: Gaurav Singh <gaurav3017@gmail.com> * chore (Box): Deprecate old Box component (#406) * fix: update version in package.json * chore: deprecate old box * chore: update package version * chore: update comment --------- Co-authored-by: Gaurav Singh <gaurav3017@gmail.com> Co-authored-by: Pratik Kumar Singh <56654568+singh-pk@users.noreply.github.com> Co-authored-by: Rishabh Mishra <me@rsbh.dev> * fix: dropdown in breadcrumb and table (#409) * feat: breadcrumb `as` support (#410) * feat: breadcrumb as support * feat: update docs * fix: Tooltip.Arrow style (#412) * feat: tooltip arrow style changes * feat: update doc * feat: multi select support (#415) * wip: select * wip: multiselect * feat: multi select * feat: update doc * chore: update types * chore: revert types * feat: auto chip logic * fix: double click on keyboard use * fix: avatar circular dependency * fix: aria tags * fix: multi select aria tag * feat: children render prop * feat: style changes * chore: sync main into develop (#419) * Feat: Add Skeleton component (#381) * feat(calendar): handle loading state (#382) * feat(calendar): handle loading state * chore: minor refactor * fix: ci breaking as checkout position incorrect (#391) * Revert/workflow 4573 (#392) * fix (CI): Workflow breaking (#393) fix: update release workflow to enforce branch and tag rules * fix: update version in package.json (#394) * fix: update version in package.json * fix: add ref * feat: Support for `as` in Sidebar.Item (#386) * feat: as support for sidebar item * feat: update props in doc * Feat: Setup Code formatting, linting and import sorter (#384) * feat: grid component (#383) * feat: grid component * feat: grid doc * fix: Error prop not overriding for date-picker (#398) * Fix release files tag main (#404) * ci: create release file for rc tags * fix: update tag regex in github action * fix: Error prop not overriding for date-picker (#402) * fix: Error prop not overriding for date-picker * fix: Error prop not overriding for date-picker --------- Co-authored-by: Gaurav Singh <gaurav3017@gmail.com> * chore (Box): Deprecate old Box component (#406) * fix: update version in package.json * chore: deprecate old box * chore: update package version * chore: update comment * chore: IconButton icon take size from parent (#411) * fix: HTML sub element coming on top of thead during table content scroll (#413) * fix (Sidebar): Item and container css fixes (#414) fix: minor css fixes * Fix/sidebar toggle position (#417) * fix (sidebar): toggle on border click position * chore: remove -2 padding * chore: change resize cursor type * feat: tooltip `followCursor` mode (#418) * wip: tooltip follow * feat: tooltip follow mode * fix: clean up tooltip code * fix: missing tooltip arrow changes * chore: remove duplicate id prop --------- Co-authored-by: Rohan Chakraborty <irohan1999@gmail.com> Co-authored-by: Pratik Kumar Singh <56654568+singh-pk@users.noreply.github.com> Co-authored-by: Rishabh Mishra <me@rsbh.dev> * Chore/sync main into develop (#420) * Feat: Add Skeleton component (#381) * feat(calendar): handle loading state (#382) * feat(calendar): handle loading state * chore: minor refactor * fix: ci breaking as checkout position incorrect (#391) * Revert/workflow 4573 (#392) * fix (CI): Workflow breaking (#393) fix: update release workflow to enforce branch and tag rules * fix: update version in package.json (#394) * fix: update version in package.json * fix: add ref * feat: Support for `as` in Sidebar.Item (#386) * feat: as support for sidebar item * feat: update props in doc * Feat: Setup Code formatting, linting and import sorter (#384) * feat: grid component (#383) * feat: grid component * feat: grid doc * fix: Error prop not overriding for date-picker (#398) * Fix release files tag main (#404) * ci: create release file for rc tags * fix: update tag regex in github action * fix: Error prop not overriding for date-picker (#402) * fix: Error prop not overriding for date-picker * fix: Error prop not overriding for date-picker --------- Co-authored-by: Gaurav Singh <gaurav3017@gmail.com> * chore (Box): Deprecate old Box component (#406) * fix: update version in package.json * chore: deprecate old box * chore: update package version * chore: update comment * chore: IconButton icon take size from parent (#411) * fix: HTML sub element coming on top of thead during table content scroll (#413) * fix (Sidebar): Item and container css fixes (#414) fix: minor css fixes * Fix/sidebar toggle position (#417) * fix (sidebar): toggle on border click position * chore: remove -2 padding * chore: change resize cursor type * feat: tooltip `followCursor` mode (#418) * wip: tooltip follow * feat: tooltip follow mode * fix: clean up tooltip code * fix: missing tooltip arrow changes --------- Co-authored-by: Rohan Chakraborty <irohan1999@gmail.com> Co-authored-by: Pratik Kumar Singh <56654568+singh-pk@users.noreply.github.com> Co-authored-by: Rishabh Mishra <me@rsbh.dev> --------- Co-authored-by: Rohan Chakraborty <irohan1999@gmail.com> Co-authored-by: Rishabh Mishra <me@rsbh.dev> Co-authored-by: Gaurav Singh <gaurav3017@gmail.com> Co-authored-by: Pratik Kumar Singh <56654568+singh-pk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
Type of Change
How Has This Been Tested?
[Describe the tests that you ran to verify your changes]
Checklist:
Screenshots (if appropriate):
[Add screenshots here]
Related Issues
[Link any related issues here using #issue-number]