Skip to content

fix: DisplayControls styles#765

Merged
rohanchkrabrty merged 3 commits intomainfrom
worktree-datatable-displaycontrols-styles
Apr 30, 2026
Merged

fix: DisplayControls styles#765
rohanchkrabrty merged 3 commits intomainfrom
worktree-datatable-displaycontrols-styles

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Resize the DisplayControls popover to 352px wide with radius-3 to match the Figma spec.
  • Update Ordering, Grouping, and Display Properties section labels to use secondary foreground color and Body/Small Plus typography.
  • Fix label width at 154px and let the right-side control flex, with gap-3 between the Ordering select and its sort icon button.
  • Use gap-5 between the Display Properties title and chip wrap.
  • Apply biome formatting to the popover CSS.

rohanchkrabrty and others added 2 commits April 30, 2026 00:18
Update spacing, typography tokens, and layout to match the Figma spec for
DataTable's DisplayControls popover:

- Container width 352px and radius-3 (was 300px min-width, default radius).
- Section labels (Ordering, Grouping, Display Properties) use secondary
  foreground color and Body/Small Plus typography.
- Fix label width at 154px and let the right-side control flex to fill,
  with a gap-3 (8px) between the Ordering select and its sort icon button.
- Display Properties uses gap-5 between its title and the chip wrap.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Apr 30, 2026 8:47am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46c0b069-9359-4ff4-a78b-f8bd57aaea96

📥 Commits

Reviewing files that changed from the base of the PR and between fddcf49 and 1f6ff97.

📒 Files selected for processing (5)
  • apps/www/src/app/examples/datatable/page.tsx
  • packages/raystack/components/data-table/components/display-properties.tsx
  • packages/raystack/components/data-table/components/grouping.tsx
  • packages/raystack/components/data-table/components/ordering.tsx
  • packages/raystack/components/data-table/data-table.module.css

📝 Walkthrough

Walkthrough

The pull request updates the DataTable example page to use client-side mode instead of server-side pagination, removing pagination state management and loading functions while supplying the full sample dataset. Simultaneously, multiple popover components within the DataTable system—specifically the display properties, grouping, and ordering controls—undergo layout and styling refinements to improve visual consistency. The CSS module is refactored to use flex-based layouts with explicit gap spacing and new utility classes, replacing previous fixed-width calculations. Column definitions in the example are expanded to enable sorting and grouping functionality across additional fields.

Suggested reviewers

  • rsbh
  • paanSinghCoder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title style(data-table): align DisplayControls popover with Figma fix: DisplayControls styles Apr 29, 2026
@rohanchkrabrty rohanchkrabrty merged commit 11254e0 into main Apr 30, 2026
3 of 5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the worktree-datatable-displaycontrols-styles branch April 30, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants