fix: DisplayControls styles#765
Conversation
Update spacing, typography tokens, and layout to match the Figma spec for DataTable's DisplayControls popover: - Container width 352px and radius-3 (was 300px min-width, default radius). - Section labels (Ordering, Grouping, Display Properties) use secondary foreground color and Body/Small Plus typography. - Fix label width at 154px and let the right-side control flex to fill, with a gap-3 (8px) between the Ordering select and its sort icon button. - Display Properties uses gap-5 between its title and the chip wrap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe pull request updates the DataTable example page to use client-side mode instead of server-side pagination, removing pagination state management and loading functions while supplying the full sample dataset. Simultaneously, multiple popover components within the DataTable system—specifically the display properties, grouping, and ordering controls—undergo layout and styling refinements to improve visual consistency. The CSS module is refactored to use flex-based layouts with explicit gap spacing and new utility classes, replacing previous fixed-width calculations. Column definitions in the example are expanded to enable sorting and grouping functionality across additional fields. Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Summary
radius-3to match the Figma spec.gap-3between the Ordering select and its sort icon button.gap-5between the Display Properties title and chip wrap.