Skip to content

fix: add missing props in migration doc#804

Merged
rohanchkrabrty merged 1 commit into
mainfrom
fix-migration-doc
May 13, 2026
Merged

fix: add missing props in migration doc#804
rohanchkrabrty merged 1 commit into
mainfrom
fix-migration-doc

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

Add missing props for Menu in v1-migration.md

@rohanchkrabrty rohanchkrabrty self-assigned this May 13, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment May 13, 2026 5:24am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9801fc42-435b-4cde-9e2e-249abb7a5621

📥 Commits

Reviewing files that changed from the base of the PR and between 055019e and 185c4f6.

📒 Files selected for processing (1)
  • docs/V1-migration.md

📝 Walkthrough

Walkthrough

This pull request updates the V1 migration guide to improve documentation accuracy and navigation. The Table of Contents gains a new "Overlay Tokens" entry and expands "New Features" subsections for eight components. The DropdownMenu → Menu migration section receives comprehensive updates: code examples now use the new Menu.Content API with side/align properties instead of placement, sideOffset instead of gutter, and the prop-mapping table documents the updated onOpenChange signature (accepting open and eventDetails), the transition from asChild to render, removal of legacy props, and component renames like DropdownMenu.TriggerItemMenu.SubmenuTrigger.

Suggested reviewers

  • rohilsurana
  • paanSinghCoder
  • rsbh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: add missing props in migration doc' clearly relates to the main change: adding missing props for Menu in the migration documentation.
Description check ✅ Passed The description 'Add missing props for Menu in v1-migration.md' directly addresses the changeset, which updates the migration guide to include missing Menu props.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty merged commit 8ccfc9a into main May 13, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-migration-doc branch May 13, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants