Skip to content

fix: match link font-size to surrounding content#97

Merged
rsbh merged 1 commit into
mainfrom
fix/link-font-size
May 21, 2026
Merged

fix: match link font-size to surrounding content#97
rsbh merged 1 commit into
mainfrom
fix/link-font-size

Conversation

@rsbh
Copy link
Copy Markdown
Member

@rsbh rsbh commented May 21, 2026

Summary

  • Add font-size: inherit to .content a in both themes
  • Links now match the font-size of their parent element

Test plan

  • Links inside paragraphs match paragraph font-size
  • Links inside list items match list item font-size
  • Standalone links in content area match content font-size

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
chronicle Ready Ready Preview, Comment May 21, 2026 3:40am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 73079822-e6db-47ce-a18b-c82106de3471

📥 Commits

Reviewing files that changed from the base of the PR and between 9acd409 and e4b2b5f.

📒 Files selected for processing (2)
  • packages/chronicle/src/themes/default/Page.module.css
  • packages/chronicle/src/themes/paper/Page.module.css

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Improved consistency of link font sizing within content areas across themes to ensure uniform typography display.

Walkthrough

This PR adds a CSS rule to both the default and paper theme page modules, ensuring that anchor links inside the .content container inherit their font size from the parent element. The change applies consistently across both themes to maintain uniform link typography.

Changes

Link Font Size Inheritance

Layer / File(s) Summary
Link styling across default and paper themes
packages/chronicle/src/themes/default/Page.module.css, packages/chronicle/src/themes/paper/Page.module.css
Both theme modules add .content a { font-size: inherit; } to ensure anchor elements inherit the parent container's font size, standardizing typography behavior for links within page content across themes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • paanSinghCoder
  • rohanchkrabrty
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding font-size inheritance to links in content areas across both themes.
Description check ✅ Passed The description clearly relates to the changeset, explaining the purpose of the CSS changes and providing a concrete test plan for validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/link-font-size

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsbh rsbh merged commit a293597 into main May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants