Skip to content

refactor(api): migrate v1 to v1beta1 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2022
Merged

refactor(api): migrate v1 to v1beta1 #61

merged 2 commits into from
Jan 17, 2022

Conversation

@mabdh
Copy link
Member

@mabdh mabdh commented Jan 12, 2022 •
edited
Loading

  • Instead of removing v1 base URL, I am duplicating the API to v1beta1
  • Will remove the v1 in the near future

@mabdh mabdh linked an issue Jan 12, 2022 that may be closed by this pull request
refactor(api): refactor v1 API to v1beta1 #57
Closed
StewartJingga
StewartJingga approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code's LGTM, but need to check on integration whether newrelic catch the routes properly.
There was an issue before regarding handlers not being set on root router.

@StewartJingga StewartJingga merged commit 8bee2d6 into main Jan 17, 2022
@StewartJingga StewartJingga deleted the migrate-v1beta1 branch January 17, 2022 10:15
@mabdh mabdh self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees

@mabdh mabdh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(api): refactor v1 API to v1beta1

3 participants

@mabdh @StewartJingga