Merged
Conversation
…in OdpfParsedMessage
prakharmathur82
approved these changes
Aug 30, 2022
ravisuhag
pushed a commit
that referenced
this pull request
Aug 31, 2022
* Initial commit: add class diagram * move diagram to docs/sinks * Add config files * Add files for KeyValue mode support * Refactor: follow checkstyle * Add and use REDIS_VALUE_BY_NAME property * Add logic for parsing key templates * Use JsonPath for nested Proto and Json field by name support * add config SINK_DEFAULT_DATATYPE_STRING_ENABLE, add getFieldByName() in OdpfParsedMessage * Fix instrumentation, error handling * Add logic to extract nested Proto fields * Simplify getFieldByName for proto, follow consistent convention for json fields * Optimization: cache schema mapping * Ref: Move Json parsing code to statis util method * Fix getMapping caching, move common code to RedisParser from RedisKeyValueParser * Add List parser module * Add Hashset parser module * Consistent key template formatting * Add tests for ttl, dataentry, parsers packages * Add test for JsonUtils class * Minor refactor, fix tests * Add tests for redis/client package * Add tests for redis/parsers package * Fix RedisHashSetParserTest * chore: review changes * test: add test for parseKeyTemplate(), fix test after review changes * fix client tests * feat: added response parsing * Reduce parseKey code, add test for multiple variables in template, fix tests * fix: review comments * chore: rearrange packages * chore: refactor packages * fix and add tests, checkstyle * chore: fix tests, improve coverage * Add test for getErrorsFromResponse() method * chore: minor change * Add RedisParserTest, optimize getSchema in RedisParser * feat: Template abstraction * chore: move entry package inside client * Fix tests * Add RedisSinkTest * Add StandaloneClientClientTest * Improve client tests * Fix Entry tests * add TTL response * fix: template constructor should validate arguments * chore: fix checkstyle * tests: add test for entries * tests: add tests for redis clients * fix: remove schema from entry classes * fix: minor fixes after qa Co-authored-by: Vinay Verma <vinayverma610@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.