Conversation
lavkesh
force-pushed
the
optimise-field-functions
branch
from
52393e1 to
53d5b6a
Compare
lavkesh
force-pushed
the
optimise-field-functions
branch
from
53d5b6a to
9daef0a
Compare
h4rikris
reviewed
Oct 6, 2022
| @@ -129,19 +129,22 @@ private void addRepeatedFields(Map<String, Object> row, Object value, List<Objec | |||
|
|
|||
|
|
|||
| public Object getFieldByName(String name, OdpfMessageSchema odpfMessageSchema) { | |||
Member
There was a problem hiding this comment.
Do we need odpfMessageSchema argument? I see that two implementations of ParsedOdpfMessage doesn't use this argument anymore.
Member
Author
There was a problem hiding this comment.
I might be needed for others. Because the schema is not part of the message. we need to supply from outside.
h4rikris
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.