feat: add helm provider #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ishanarya0
force-pushed
the
helm-provider
branch
from
00f6eee to
88f5607
Compare
Member
Author
|
Upgraded golang to version |
rohilsurana
reviewed
Mar 21, 2022
pkg/provider/helm/release.go
Outdated
| func (p *Provider) create(config *releaseConfig) (*Release, error) { | ||
| actionConfig, err := p.getActionConfiguration(config.Namespace) | ||
| if err != nil { | ||
| return nil, err |
Member
There was a problem hiding this comment.
Let's wrap these errors into our own error. It will make it easier to handle errors where we use this methods.
rohilsurana
reviewed
Mar 21, 2022
pkg/provider/helm/release.go
Outdated
| }, chartName, nil | ||
| } | ||
|
|
||
| func resolveChartName(repository, name string) (string, string, error) { |
Member
There was a problem hiding this comment.
we can get rid of return value error as it is always nil.
rohilsurana
approved these changes
Mar 21, 2022
Member
Author
|
Merge conflicts resolved @rohilsurana |
ishanarya0
force-pushed
the
helm-provider
branch
from
282684f to
14c8285
Compare
Meghajit
pushed a commit
to Meghajit/entropy
that referenced
this pull request
May 4, 2023
This reverts commit 2b799d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: