feat(actions): add actions endpoint #26

rohilsurana · 2022-03-16T12:12:53Z

Fixes #8

api/handlers/v1/resource.go

modules/log/module.go

pkg/module/service.go

modules/log/module.go

api/handlers/v1/resource.go

pkg/module/service_test.go

modules/log/module.go

krtkvrm · 2022-03-21T04:59:49Z

api/handlers/v1/resource.go

+		if errors.Is(err, store.ResourceNotFoundError) {
+			return nil, status.Error(codes.NotFound, "could not find resource with given urn")
+		}
+		return nil, status.Error(codes.Internal, "failed to apply fetch resource from db")


before returning back resp to the client, how about logging the error as well ?

Will take this up as a separate issue, initially was thinking of keeping the logging limited to the middleware. Will check if there is a way to log these details but skip sending to client at the same time.

Yes ideally, every internal server error should be logged out.

feat(actions): add action endpoint

7164bda

rohilsurana requested review from AkarshSatija, mabdh, rahmatrhd and whoAbhishekSah March 16, 2022 12:12

mabdh reviewed Mar 17, 2022

View reviewed changes

rohilsurana added 2 commits March 17, 2022 09:54

fix: move proton go build to odpf/proton

673488e

refactor: use constants for repeated strings in modules/log

6dfb5ef