chore: error variable name changed #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's fix domain/module.go:8:2: the variable name |
Member
Author
Done. This PR is ready for approval and merge. |
rohilsurana
pushed a commit
that referenced
this pull request
Apr 7, 2022
* feat: provider framework to pass creds to k8s/helm provider * chore: err var name restored * feat: pass providers in resource payload * feat: add provider service * chore: remove unused constants * chore: error variable name changed (#28) * chore: error variable name changed as per golang convention * fix: change error name ErrModuleConfigParseFailed * feat: provider framework to pass creds to k8s/helm provider * chore: err var name restored * feat: pass providers in resource payload * feat: add provider service * chore: remove unused constants * chore: resolve merge conflicts * chore: err var name restored * chore: resolve merge conflicts * chore: proton version update * chore: remove log statements * refactor: improved map-struct-value conversion * feat: validate full resource config * fix: remove unnecessary error block * fix: move firehose defaults to module
Meghajit
pushed a commit
to Meghajit/entropy
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error variable names updated as per golang convention