Skip to content

feat(modules/firehose): add custom actions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohilsurana merged 5 commits into from
Apr 12, 2022
Merged

feat(modules/firehose): add custom actions #32

rohilsurana merged 5 commits into from
Apr 12, 2022

Conversation

@ishanarya0
Copy link
Member

@ishanarya0 ishanarya0 commented Apr 8, 2022 •
edited
Loading

  • Scale - takes in the replicas and scales the firehose workers accordingly
  • Stop - scales down the deployment to 0. It should also remember the previous state
  • Start - scales a previously stopped firehose deployment to its older state of replicas

@ishanarya0 ishanarya0 linked an issue Apr 8, 2022 that may be closed by this pull request
[Module][Firehose] Implement custom actions #14
Closed
3 tasks
@ishanarya0 ishanarya0 requested review from rohilsurana and spy16 April 8, 2022 07:36
spy16
spy16 reviewed Apr 11, 2022
View reviewed changes
@rohilsurana rohilsurana self-requested a review April 12, 2022 08:13
rohilsurana
rohilsurana reviewed Apr 12, 2022
View reviewed changes
@ishanarya0 ishanarya0 requested a review from rohilsurana April 12, 2022 08:42
@rohilsurana rohilsurana merged commit b8862da into main Apr 12, 2022
@rohilsurana rohilsurana deleted the firehose-custom-act branch April 12, 2022 10:08
Meghajit pushed a commit to Meghajit/entropy that referenced this pull request May 4, 2023
@spy16
fix: remove name label to prevent length issues (raystack#32)
4538cb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

@spy16 spy16 spy16 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Module][Firehose] Implement custom actions

4 participants

@ishanarya0 @rohilsurana @spy16