Skip to content

feat: add json schema conditional validations #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohilsurana merged 5 commits into from
Jul 1, 2022
Merged

feat: add json schema conditional validations #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0f6068
feat: add json schema conditional validations
ishanarya0 Jun 21, 2022
eb019ed
test: add JSONSchema tests
ishanarya0 Jun 29, 2022
1e638e7
fix: linting issues
ishanarya0 Jun 29, 2022
8d3bbfb
fix: remove unnecessary imports
ishanarya0 Jun 29, 2022
edb9972
fix(kubernetes): add check for host field for URI format and http/s p…
rohilsurana Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 51 additions & 3 deletions modules/kubernetes/config_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
"type": "object",
"properties": {
"host": {
"type": "string"
"type": "string",
"format": "uri",
"pattern": "^https?://"
},
"insecure": {
"type": "boolean",
Expand All @@ -28,7 +30,53 @@
"default": 100000000
}
},
"required": [
"host"
"allOf": [
{
"oneOf": [
{
"required": [
"token"
]
},
{
"allOf": [
{
"required": [
"client_key"
]
},
{
"required": [
"client_certificate"
]
}
]
}
]
},
{
"oneOf": [
{
"required": [
"cluster_ca_certificate"
]
},
{
"properties": {
"insecure": {
"const": true
}
},
"required": [
"insecure"
]
}
]
},
{
"required": [
"host"
]
}
]
}
113 changes: 113 additions & 0 deletions modules/kubernetes/config_schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
package kubernetes

import (
"errors"
"testing"

"github.com/stretchr/testify/assert"
"github.com/xeipuuv/gojsonschema"
)

func TestModule_KubernetesJSONSchema(t *testing.T) {
tests := []struct {
Case string
wantErr error
want bool
}{
{
Case: `{
"host": "http://0.0.0.0:1234",
"insecure": true,
"token": "token"
}`,
wantErr: nil,
want: true,
},
{
Case: `{
"host": "http://0.0.0.0:1234",
"insecure": false,
"token": "token"
}`,
wantErr: nil,
want: false,
},
{
Case: `{
"host": "http://0.0.0.0:1234",
"insecure": false,
"cluster_ca_certificate": "c_ca_cert",
"token": "token"
}`,
wantErr: nil,
want: true,
},
{
Case: `{
"host": "http://0.0.0.0:1234",
"cluster_ca_certificate": "c_ca_cert",
"token": "token"
}`,
wantErr: nil,
want: true,
},
{
Case: `{
"host": "http://0.0.0.0:1234",
"insecure": true,
"client_key": "c_key",
"client_certificate": "c_cert"
}`,
wantErr: nil,
want: true,
},
{
Case: ` "host": "http://0.0.0.0:1234",
"insecure": true,
"client_key": "c_key"
}`,
wantErr: nil,
want: false,
},
{
Case: `{
"host": "http://0.0.0.0:1234",
"insecure": true,
"token": "token",
"client_key": "c_key",
"client_certificate": "c_cert"
}`,
wantErr: nil,
want: false,
},
{
Case: `{
"host": "http://0.0.0.0:1234",
"insecure": true,
"token": "token",
"client_key": "c_key"
}`,
wantErr: nil,
want: true,
},
}
loader := gojsonschema.NewStringLoader(configSchema)
schema, _ := gojsonschema.NewSchema(loader)

for _, tt := range tests {
tt := tt
t.Run(tt.Case, func(t *testing.T) {
t.Parallel()

c := gojsonschema.NewStringLoader(tt.Case)
result, err := schema.Validate(c)
if tt.wantErr != nil {
assert.Error(t, err)
assert.True(t, errors.Is(err, tt.wantErr))
} else {
assert.NoError(t, err)
}
assert.Equal(t, tt.want, result.Valid())
})
}
}