Skip to content

fix: handle duplicate enqueue error #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohilsurana merged 1 commit into from
Aug 2, 2022
Merged

fix: handle duplicate enqueue error #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/worker/job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const (
)

var (
ErrJobExists = errors.New("job with id exists")
ErrInvalidJob = errors.New("job is not valid")
ErrKindExists = errors.New("handler for given kind exists")
ErrUnknownKind = errors.New("job kind is invalid")
Expand Down
6 changes: 5 additions & 1 deletion pkg/worker/pgq/pgq.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"time"

sq "github.com/Masterminds/squirrel"
_ "github.com/lib/pq" // postgres driver.
"github.com/lib/pq"

"github.com/odpf/entropy/pkg/errors"
"github.com/odpf/entropy/pkg/worker"
Expand Down Expand Up @@ -86,6 +86,10 @@ func (q *Queue) Enqueue(ctx context.Context, jobs ...worker.Job) error {

_, err := insertQuery.RunWith(q.db).PlaceholderFormat(sq.Dollar).ExecContext(ctx)
if err != nil {
pqErr := &pq.Error{}
if errors.As(err, &pqErr) && pqErr.Code.Name() == "unique_violation" {
return worker.ErrJobExists
}
return err
}
return nil
Expand Down