Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rohanchkrabrty
requested review from
paanSinghCoder,
rohilsurana and
rsbh
and removed request for
paanSinghCoder,
rohilsurana and
rsbh
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (27)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the 📝 WalkthroughWalkthroughThis PR refactors organization, members, projects, and teams management by consolidating route-based nested components into view-layer page components. It removes scattered route handlers and delegates UI logic to new page abstractions, replacing route-based navigation with callback-driven control and converting several modals to controlled components. Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~110 minutes Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohanchkrabrty
added
the
Do not merge
rsbh
approved these changes
Feb 27, 2026
Pull Request Test Coverage Report for Build 22562107314Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
rohanchkrabrty
removed
the
Do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate SDK project pages (list + detail) from router-coupled components to standalone view components, following the established pattern from general, members, and teams migrations.
Changes
react/views/projects/withlist/anddetails/subdirectoriesopen/onOpenChangepropsuseParamsanduseNavigatein view components with explicit props (projectId,onProjectClick,onBack)useNavigatecalls with callback props (onProjectClick,onDeleteProjectClick)DeleteProjectDialogto the projects list page so delete action works from the dropdown menucomponents/organization/project/that bridge router params to view props/projects/modal,/projects/$projectId/delete,/projects/$projectId/$membertype/$memberId/remove) fromroutes.tsxmemberTypethreading from remove-member callback chainTechnical Details
@tanstack/react-routerimports — all routing is isolated in thin wrappers{ open, projectId }) following the members/teams patterncomponents/organization/styles.module.cssviews/projects/index.tsexpose all page and dialog components with their prop types