Skip to content

feat: move sdk api#1429

Merged
rohanchkrabrty merged 15 commits intomainfrom
move-sdk-api
Mar 2, 2026
Merged

feat: move sdk api#1429
rohanchkrabrty merged 15 commits intomainfrom
move-sdk-api

Conversation

@rohanchkrabrty
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty commented Feb 26, 2026

Summary

  • Migrated API Keys components from components/organization/api-keys/ to views/api-keys/ (list + detail pattern)
  • Converted 4 route-based modal dialogs to state-based: AddServiceAccountDialog, DeleteServiceAccountDialog, DeleteServiceUserKeyDialog, ManageServiceUserProjectsDialog
  • Replaced TanStack Router dependencies (useNavigate, useParams, useLocation, Link, Outlet) with callback props and explicit entity ID props
  • Created thin wrappers in components/organization/api-keys/ for route compatibility
  • Removed 4 child routes from routes.tsx (addServiceAccountRoute, deleteServiceAccountRoute, deleteServiceAccountKeyRoute, serviceAccountProjectRoute)

@rohanchkrabrty rohanchkrabrty added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Feb 26, 2026
@rohanchkrabrty rohanchkrabrty self-assigned this Feb 26, 2026
@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 2, 2026 5:41am

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Warning

Rate limit exceeded

@rohanchkrabrty has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 820638e and 44ad4d7.

📒 Files selected for processing (17)
  • web/sdk/react/components/organization/api-keys/index.tsx
  • web/sdk/react/components/organization/api-keys/service-user/index.tsx
  • web/sdk/react/components/organization/routes.tsx
  • web/sdk/react/views/api-keys/details/add-service-user-token.tsx
  • web/sdk/react/views/api-keys/details/delete-service-user-key-dialog.tsx
  • web/sdk/react/views/api-keys/details/index.ts
  • web/sdk/react/views/api-keys/details/manage-service-user-projects-dialog.tsx
  • web/sdk/react/views/api-keys/details/service-user-detail-page.tsx
  • web/sdk/react/views/api-keys/details/service-user.module.css
  • web/sdk/react/views/api-keys/hooks/useServiceUserTokens.ts
  • web/sdk/react/views/api-keys/index.ts
  • web/sdk/react/views/api-keys/list/add-service-account-dialog.tsx
  • web/sdk/react/views/api-keys/list/api-keys-columns.tsx
  • web/sdk/react/views/api-keys/list/api-keys-list-page.tsx
  • web/sdk/react/views/api-keys/list/api-keys.module.css
  • web/sdk/react/views/api-keys/list/delete-service-account-dialog.tsx
  • web/sdk/react/views/api-keys/list/index.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@paanSinghCoder paanSinghCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check page - view file renaming.

@rohanchkrabrty rohanchkrabrty removed the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Mar 2, 2026
Base automatically changed from move-sdk-tokens to main March 2, 2026 05:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22562949751

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.848%

Totals Coverage Status
Change from base Build 22562927418: 0.0%
Covered Lines: 13595
Relevant Lines: 34117

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty merged commit 6599d34 into main Mar 2, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the move-sdk-api branch March 2, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants