Skip to content

fix: add tooltip for row text#1451

Merged
paanSinghCoder merged 4 commits intomainfrom
fix/table-tooltip
Mar 17, 2026
Merged

fix: add tooltip for row text#1451
paanSinghCoder merged 4 commits intomainfrom
fix/table-tooltip

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Mar 17, 2026

Summary

  • Show full description on hover via Tooltip. Cell text truncates with ellipsis, tooltip uses apsara Tooltip with delayDuration={500}.
  • Date and Tokens columns constrained with styles: { header: { width: "180px" } }
truncate.mov

Future enhancement: Tooltip shows always, irrespective of the text is truncated or not.

  • Detecting truncation (e.g. scrollWidth vs clientWidth) needs a ResizeObserver (or similar) per cell. Doing that in each column/cell is not scalable (many observers, repeated logic).
  • A better approach is to support this in DataTable: e.g. a column option like showTooltipWhenTruncated and optional tooltip content, with a single ResizeObserver (or shared logic) inside the table. That keeps the feature in one place and avoids N observers per table. Left for a follow-up.

Technical Details

Test Plan

  • Manual testing completed
  • Build and type checking passes

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 17, 2026 6:19am

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Warning

Rate limit exceeded

@paanSinghCoder has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 04765855-da9d-4620-bc04-d2712b3f1c82

📥 Commits

Reviewing files that changed from the base of the PR and between 0df765d and bb8e932.

📒 Files selected for processing (2)
  • web/sdk/admin/views/organizations/details/tokens/columns.tsx
  • web/sdk/admin/views/organizations/details/tokens/tokens.module.css
📝 Walkthrough

Walkthrough

This change adds tooltip functionality to truncated text in the tokens column, displaying full descriptions on hover. It introduces CSS classes for text truncation and tooltip styling, plus sets fixed header widths for the Date and Tokens columns in the tokens management interface.

Changes

Cohort / File(s) Summary
Token Description Tooltip Enhancement
web/sdk/admin/views/organizations/details/tokens/columns.tsx, web/sdk/admin/views/organizations/details/tokens/tokens.module.css
Adds Tooltip component wrapping to description text in Events column with conditional rendering. Introduces .truncate-text CSS class for ellipsis truncation and .truncate-tooltip-wrapper>* rule for full-width tooltip rendering. Sets fixed header widths: Date column 180px, Tokens column 220px.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@paanSinghCoder paanSinghCoder self-assigned this Mar 17, 2026
@paanSinghCoder paanSinghCoder added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 17, 2026
@paanSinghCoder paanSinghCoder requested a review from rsbh March 17, 2026 05:59
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 23180602837

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.56%

Totals Coverage Status
Change from base Build 23133351460: 0.0%
Covered Lines: 14204
Relevant Lines: 35020

💛 - Coveralls

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
web/sdk/admin/views/organizations/details/tokens/columns.tsx (1)

62-70: Consider simplifying the wrapper structure.

The current implementation uses a nested wrapper pattern. Based on the context snippet from sidepanel-list-id.tsx, a simpler approach applies the truncation class directly to the element inside the Tooltip without an additional wrapper span:

<Tooltip message={text} delayDuration={500}>
  <span className={styles["truncate-text"]}>{text}</span>
</Tooltip>

This approach is simpler and aligns with existing patterns in the codebase. However, for truncation to work correctly, the truncate-text class may need explicit width constraints (e.g., width: 100% and display: block), since table cells don't automatically constrain inline children.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dae15259-0c83-4720-b46f-ac0aba694054

📥 Commits

Reviewing files that changed from the base of the PR and between d197b94 and 0df765d.

📒 Files selected for processing (2)
  • web/sdk/admin/views/organizations/details/tokens/columns.tsx
  • web/sdk/admin/views/organizations/details/tokens/tokens.module.css

@paanSinghCoder paanSinghCoder enabled auto-merge (squash) March 17, 2026 06:20
@paanSinghCoder paanSinghCoder merged commit 0755212 into main Mar 17, 2026
8 checks passed
@paanSinghCoder paanSinghCoder deleted the fix/table-tooltip branch March 17, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants