Skip to content

chore(web): remove unused custom-fetch and dead fetcher utility#1523

Open
rsbh wants to merge 2 commits intomainfrom
chore-remove-dead-fetch-code
Open

chore(web): remove unused custom-fetch and dead fetcher utility#1523
rsbh wants to merge 2 commits intomainfrom
chore-remove-dead-fetch-code

Conversation

@rsbh
Copy link
Copy Markdown
Member

@rsbh rsbh commented Apr 9, 2026

Summary

  • Remove custom-fetch.ts from client-demo app (unused outside connect-rpc transport)
  • Remove dead fetcher utility from admin helper.ts (not imported anywhere)

Test plan

  • Lint passes on changed files
  • Build failure is pre-existing on main (unrelated @radix-ui/react-icons issue)

🤖 Generated with Claude Code

rsbh and others added 2 commits April 9, 2026 14:49
Remove custom-fetch.ts from client-demo as it was not needed and
remove unused fetcher export from admin helper utils.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Apr 9, 2026 9:29am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 54b507df-c67c-4067-9a3d-3a50a77dba98

📥 Commits

Reviewing files that changed from the base of the PR and between e5de5bd and 2a840d9.

⛔ Files ignored due to path filters (1)
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • web/apps/admin/package.json
  • web/apps/admin/scripts/gen-swagger-client.mjs
  • web/apps/admin/src/utils/helper.ts
  • web/apps/client-demo/src/App.tsx
  • web/apps/client-demo/src/utils/custom-fetch.ts
💤 Files with no reviewable changes (4)
  • web/apps/client-demo/src/App.tsx
  • web/apps/client-demo/src/utils/custom-fetch.ts
  • web/apps/admin/src/utils/helper.ts
  • web/apps/admin/scripts/gen-swagger-client.mjs

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed unused Swagger API client generation build script and associated dependency.
    • Removed unused custom fetch utility function.
    • Cleaned up related configuration from dependent components.

Walkthrough

Removes Swagger client generation infrastructure and custom fetch utilities from the admin and client-demo applications, including the swagger-typescript-api dependency, the client generation script, custom fetch wrapper, and related imports across multiple files.

Changes

Cohort / File(s) Summary
Admin App Build Configuration
web/apps/admin/package.json, web/apps/admin/scripts/gen-swagger-client.mjs
Removed build:client npm script and eliminated swagger-typescript-api devDependency that powered the Swagger-to-TypeScript client generation workflow.
Admin App Utilities
web/apps/admin/src/utils/helper.ts
Removed the untyped fetcher export that wrapped fetch() calls and returned parsed JSON responses.
Client-Demo App Custom Fetch
web/apps/client-demo/src/utils/custom-fetch.ts, web/apps/client-demo/src/App.tsx
Eliminated the customFetch utility function that injected request-scoped headers (X-Request-Id, X-Frontier-Org-Id) and removed its integration from FrontierProvider initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • rohilsurana
  • paanSinghCoder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24182968309

Coverage remained the same at 41.282%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 36389
Covered Lines: 15022
Line Coverage: 41.28%
Coverage Strength: 11.88 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants