feat: add AddOrganizationMembers RPC handler#1538
Open
whoAbhishekSah wants to merge 1 commit intofeat/membership-servicefrom
Open
feat: add AddOrganizationMembers RPC handler#1538whoAbhishekSah wants to merge 1 commit intofeat/membership-servicefrom
whoAbhishekSah wants to merge 1 commit intofeat/membership-servicefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
Coverage Report for CI Build 24389918045Coverage decreased (-0.06%) to 41.726%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
1 task
whoAbhishekSah
force-pushed
the
feat/membership-handler
branch
from
70af8be to
81e031e
Compare
whoAbhishekSah
changed the title
whoAbhishekSah
force-pushed
the
feat/membership-handler
branch
from
81e031e to
be2a7cb
Compare
Wire the membership package into the AddOrganizationMembers AdminService
RPC. Batch endpoint accepts list of {user_id, role_id} pairs and returns
per-member success/error results.
- Handler iterates members, calls membershipService.AddOrganizationMember
- Domain errors (already member, invalid role, etc.) returned as-is
- Internal errors masked with generic message and logged server-side
- Authorization: IsSuperUser (AdminService)
- Proto regenerated from proton branch with new RPC
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
whoAbhishekSah
force-pushed
the
feat/membership-handler
branch
from
be2a7cb to
d9d4c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire the membership package (from #1537) into the
AddOrganizationMembersAdminService RPC.Depends on: #1537 (membership service package)
Proto depends on: raystack/proton#469
Changes
cmd/serve.go— create and injectmembershipServiceinternal/api/api.go— addMembershipServicetoDepsinternal/api/v1beta1connect/— handler, interface, wiringpkg/server/connect_interceptors/authorization.go—IsSuperUserfor AdminServiceproto/— regenerated withAddOrganizationMembersRPCMakefile— proton commit updatedHandler behavior
membershipService.AddOrganizationMemberper entryIsSuperUser)Test plan
🤖 Generated with Claude Code