Draft
Conversation
Replace go.uber.org/zap and github.com/raystack/salt/log with log/slog across the entire codebase. This removes external logging dependencies in favor of Go's built-in structured logging introduced in Go 1.21. Key changes: - Rewrite pkg/logger with slog-based InitLogger, ToContext, FromContext - Replace salt log.Logger interface with *slog.Logger throughout - Replace grpczap context propagation with custom context helpers - Convert all zap typed fields (zap.String, zap.Error) to key-value pairs - Update Connect RPC logger interceptor to use *slog.Logger - Update all tests to use slog with io.Discard handler - Remove go.uber.org/zap and grpc-zap-middleware dependencies
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.uber.org/zapandgithub.com/raystack/salt/logwith Go's standard librarylog/slogacross the entire codebase (111 files)pkg/logger/with slog-basedInitLogger,ToContext,FromContext, andFatalhelpersgo.uber.org/zap,grpc-zap-middleware) fromgo.modDetails
Foundation (
pkg/logger/):InitLogger(cfg)returns*slog.Loggerwith JSON or text handler based on configToContext/FromContextreplacegrpczap.ToContext/Extractfor request-scoped loggingFatalhelper wrapsslog.Error+os.Exit(1)since slog has no Fatal levelMigration patterns applied:
log.Logger(salt interface)*slog.Loggergrpczap.ToContext(ctx, logger)frontierlogger.ToContext(ctx, logger)grpczap.Extract(ctx)frontierlogger.FromContext(ctx)zap.String("k", v)"k", vzap.Error(err)"error", errlog.NewNoop()(tests)slog.New(slog.NewTextHandler(io.Discard, nil))Test plan
go build ./...passesgo vet ./...passesgo mod tidycleango test ./...(unit tests)zap,salt/log, orctxzap