Skip to content

chore: remove projects column from service accounts table#1589

Merged
rohanchkrabrty merged 2 commits intomainfrom
remove-service-page
Apr 30, 2026
Merged

chore: remove projects column from service accounts table#1589
rohanchkrabrty merged 2 commits intomainfrom
remove-service-page

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Remove the Projects column from the service accounts DataTable
  • Drop the ProjectsCell component along with its module CSS
  • Simplify getColumns by removing the now-unused orgId option

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Apr 30, 2026 11:03am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a545f455-af6f-4534-ade6-1c5cb74f49fc

📥 Commits

Reviewing files that changed from the base of the PR and between 9fa4b0a and 52372a2.

📒 Files selected for processing (4)
  • web/sdk/react/views-new/service-accounts/components/projects-cell.module.css
  • web/sdk/react/views-new/service-accounts/components/projects-cell.tsx
  • web/sdk/react/views-new/service-accounts/components/service-account-columns.tsx
  • web/sdk/react/views-new/service-accounts/service-accounts-view.tsx
💤 Files with no reviewable changes (2)
  • web/sdk/react/views-new/service-accounts/components/projects-cell.module.css
  • web/sdk/react/views-new/service-accounts/components/projects-cell.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Removed the Projects column from the service accounts table.

Walkthrough

This pull request removes the Projects column from the service accounts table by deleting the ProjectsCell component and its CSS module, updating column configuration to remove the orgId parameter, and removing orgId from the columns dependency list.

Changes

Cohort / File(s) Summary
Projects Cell Removal
web/sdk/react/views-new/service-accounts/components/projects-cell.module.css, web/sdk/react/views-new/service-accounts/components/projects-cell.tsx
Deletes the ProjectsCell component that queried and displayed frontier service user projects, along with its associated CSS styling for text truncation and tooltip content.
Column Configuration
web/sdk/react/views-new/service-accounts/components/service-account-columns.tsx
Removes the orgId parameter from GetColumnsOptions interface and deletes the Projects column definition from the table columns array.
View Integration
web/sdk/react/views-new/service-accounts/service-accounts-view.tsx
Stops passing orgId to getColumns and removes it from the useMemo dependency list for column recomputation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • rohilsurana
  • rsbh
  • paanSinghCoder
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) April 30, 2026 11:01
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 30, 2026

Coverage Report for CI Build 25161724925

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 41.963%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37254
Covered Lines: 15633
Line Coverage: 41.96%
Coverage Strength: 11.88 hits per line

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty merged commit ce2d607 into main Apr 30, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the remove-service-page branch April 30, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants