Skip to content

fix(billing): replace text/template with strings.Replace in checkout URL templating #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohilsurana wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −38
Open

fix(billing): replace text/template with strings.Replace in checkout URL templating #1619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97028bf
fix(billing): replace text/template with strings.Replace in checkout …
rohilsurana May 15, 2026
091670f
fix(billing): use strings.ReplaceAll instead of strings.Replace
rohilsurana May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 8 additions & 38 deletions billing/checkout/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
package checkout

import (
"bytes"
"context"
"errors"
"fmt"
"log/slog"
"strings"
"sync"
"text/template"
"time"

"github.com/robfig/cron/v3"
Expand Down Expand Up @@ -216,10 +215,7 @@ func (s *Service) Create(ctx context.Context, ch Checkout) (Checkout, error) {
}

checkoutID := uuid.New().String()
ch, err = s.templatizeUrls(ch, checkoutID)
if err != nil {
return Checkout{}, err
}
ch = s.templatizeUrls(ch, checkoutID)

currentPrincipal, err := s.authnService.GetPrincipal(ctx)
if err != nil {
Expand Down Expand Up @@ -489,34 +485,11 @@ func (s *Service) Create(ctx context.Context, ch Checkout) (Checkout, error) {
return Checkout{}, fmt.Errorf("invalid checkout request")
}

// templatizeUrls replaces the checkout id in the urls with the actual checkout id
func (s *Service) templatizeUrls(ch Checkout, checkoutID string) (Checkout, error) {
tpl := template.New("success")
t, err := tpl.Parse(ch.SuccessUrl)
if err != nil {
return Checkout{}, fmt.Errorf("failed to parse success url: %w", err)
}
var tplBuffer bytes.Buffer
if err = t.Execute(&tplBuffer, map[string]string{
"CheckoutID": checkoutID,
}); err != nil {
return Checkout{}, fmt.Errorf("failed to parse success url: %w", err)
}
ch.SuccessUrl = tplBuffer.String()

tpl = template.New("cancel")
t, err = tpl.Parse(ch.CancelUrl)
if err != nil {
return Checkout{}, fmt.Errorf("failed to parse cancel url: %w", err)
}
tplBuffer.Reset()
if err = t.Execute(&tplBuffer, map[string]string{
"CheckoutID": checkoutID,
}); err != nil {
return Checkout{}, fmt.Errorf("failed to parse cancel url: %w", err)
}
ch.CancelUrl = tplBuffer.String()
return ch, nil
// templatizeUrls replaces the checkout id placeholder in the urls with the actual checkout id
func (s *Service) templatizeUrls(ch Checkout, checkoutID string) Checkout {
ch.SuccessUrl = strings.ReplaceAll(ch.SuccessUrl, "{{.CheckoutID}}", checkoutID)
ch.CancelUrl = strings.ReplaceAll(ch.CancelUrl, "{{.CheckoutID}}", checkoutID)
return ch
}

func (s *Service) GetByID(ctx context.Context, id string) (Checkout, error) {
Expand Down Expand Up @@ -781,10 +754,7 @@ func (s *Service) CreateSessionForPaymentMethod(ctx context.Context, ch Checkout
}

checkoutID := uuid.New().String()
ch, err = s.templatizeUrls(ch, checkoutID)
if err != nil {
return Checkout{}, err
}
ch = s.templatizeUrls(ch, checkoutID)

// create payment method setup checkout link
stripeCheckout, err := s.stripeClient.CheckoutSessions.New(&stripe.CheckoutSessionParams{
Expand Down
Loading