Skip to content

fix(sdk): PAT page UI fixes and copy updates#1646

Merged
AmanGIT07 merged 9 commits into
mainfrom
pat-sdk-fixes
May 25, 2026
Merged

fix(sdk): PAT page UI fixes and copy updates#1646
AmanGIT07 merged 9 commits into
mainfrom
pat-sdk-fixes

Conversation

@rohilsurana
Copy link
Copy Markdown
Member

@rohilsurana rohilsurana commented May 25, 2026

Summary

  • Remove href="#" from breadcrumb items across all detail views (PAT, projects, service accounts, teams)
  • Change PAT warning callout from red alert to yellow attention type with ExclamationTriangleIcon
  • Fix project chips baseline alignment with label text in PAT detail view
  • Update PAT page header and empty state copy
  • Show -- for empty "Last used" field in PAT table
  • Remove unused MouseEvent import from service account details view
  • Add PAT list and detail routes to OrganizationProfile router with sidebar navigation entry

Test plan

  • Navigate to any detail page (PAT, project, team, service account) → click breadcrumb → verify correct navigation without # in URL
  • Create a new PAT → verify success dialog shows yellow warning callout with triangle icon
  • Open PAT detail page with selective projects → verify "Projects:" label aligns with chip text
  • Open PAT page with no tokens → verify empty state copy reads "Create a personal access token to securely access..."
  • Open PAT page with tokens → verify header description reads "Manage personal access tokens to securely access..."
  • Verify unused PATs show -- in the "Last used" column
  • Open OrganizationProfile (e.g. in studio) → verify "Personal Access Tokens" appears in sidebar
  • Click "Personal Access Tokens" → verify PAT list page loads
  • Click a PAT row → verify PAT detail page loads with breadcrumb
  • Click breadcrumb → verify navigation back to PAT list

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 25, 2026 9:30am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 333d9a0c-b9da-44d1-af06-69508305ef98

📥 Commits

Reviewing files that changed from the base of the PR and between a50ba67 and b4091c6.

📒 Files selected for processing (5)
  • web/sdk/react/components/organization/pat/index.tsx
  • web/sdk/react/components/organization/pat/pat.tsx
  • web/sdk/react/components/organization/routes.tsx
  • web/sdk/react/components/organization/sidebar/helpers.ts
  • web/sdk/react/views-new/pat/components/pat-columns.tsx

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added Personal Access Tokens management with dedicated pages and sidebar navigation.
    • Implemented PAT details view with navigation controls.
  • Bug Fixes

    • Improved display of missing usage data in PAT listings.
  • Style

    • Refined warning dialog styling and visual indicators.
    • Enhanced breadcrumb navigation interactions across detail pages.
  • Documentation

    • Updated user-facing descriptions for clarity on PAT security and access purposes.

Walkthrough

Breadcrumb click handlers refactored to use direct onClick callbacks across detail views. PAT created dialog callout/icon and PAT detail-row alignment updated. PAT view copy and last-used column adjusted. Workspace PAT routes, pages, and sidebar entry added.

Changes

UI Interaction and Styling Updates

Layer / File(s) Summary
Breadcrumb Navigation Pattern Refactoring
web/sdk/react/views-new/pat/pat-details-view.tsx, web/sdk/react/views-new/projects/project-details-view.tsx, web/sdk/react/views-new/service-accounts/service-account-details-view.tsx, web/sdk/react/views-new/teams/team-details-view.tsx
Breadcrumb items in PAT, Project, Service Account, and Team detail views updated from href="#" anchors with preventDefault() to direct onClick handlers using optional chaining (onNavigateTo...?.()). Service accounts view import updated to remove unused MouseEvent type.
PAT Dialog and Detail View Styling
web/sdk/react/views-new/pat/components/pat-created-dialog.tsx, web/sdk/react/views-new/pat/pat-details-view.module.css
PAT created dialog warning callout updated from type="alert" to type="attention" and now uses ExclamationTriangleIcon instead of InfoCircledIcon. PAT detail row CSS align-items changed from flex-start to baseline.
PAT View Text and List Column
web/sdk/react/views-new/pat/pat-view.tsx, web/sdk/react/views-new/pat/components/pat-columns.tsx
View header description and empty-state subheading updated to emphasize managing personal access tokens for securely accessing app resources and APIs. Last used column now shows -- when pat.usedAt is missing.
Workspace PAT Routes and Sidebar
web/sdk/react/components/organization/pat/index.tsx, web/sdk/react/components/organization/pat/pat.tsx, web/sdk/react/components/organization/routes.tsx, web/sdk/react/components/organization/sidebar/helpers.ts
Adds WorkspacePats client component and PatPage routed page, registers /pats and /pats/$patId in organization routes, and adds a "Personal Access Tokens" sidebar nav entry pointing to /pats.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • raystack/frontier#1533: Earlier PAT list/details feature work that introduced the PAT components modified here.

Suggested reviewers

  • rsbh
  • paanSinghCoder
  • rohanchkrabrty
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

coveralls commented May 25, 2026

Coverage Report for CI Build 26393564497

Coverage remained the same at 42.847%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37891
Covered Lines: 16235
Line Coverage: 42.85%
Coverage Strength: 11.96 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 32e7df8b-57a0-43d5-be5e-cf52de3e5204

📥 Commits

Reviewing files that changed from the base of the PR and between 9e2e75a and 95e0da1.

📒 Files selected for processing (6)
  • web/sdk/react/views-new/pat/components/pat-created-dialog.tsx
  • web/sdk/react/views-new/pat/components/pat-form-dialog.tsx
  • web/sdk/react/views-new/pat/pat-details-view.tsx
  • web/sdk/react/views-new/projects/project-details-view.tsx
  • web/sdk/react/views-new/service-accounts/service-account-details-view.tsx
  • web/sdk/react/views-new/teams/team-details-view.tsx

Comment thread web/sdk/react/views-new/pat/pat-details-view.tsx Outdated
@rohilsurana rohilsurana changed the title fix(sdk): fix disabled radio cursor, breadcrumb navigation, and PAT warning callout fix(sdk): PAT page UI fixes and copy updates May 25, 2026
@AmanGIT07 AmanGIT07 merged commit e24bcb7 into main May 25, 2026
8 checks passed
@AmanGIT07 AmanGIT07 deleted the pat-sdk-fixes branch May 25, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants