Skip to content

fix: IAM Design fixes#1663

Merged
rohanchkrabrty merged 2 commits into
mainfrom
fix-iam-design
Jun 1, 2026
Merged

fix: IAM Design fixes#1663
rohanchkrabrty merged 2 commits into
mainfrom
fix-iam-design

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Remove the ViewHeader (title + description) from the left-aligned empty2 zero states across views-new so only the empty state shows when a view has no data.
  • For views sharing one ViewHeader across data and zero-state paths (service-accounts, pat, billing), render it only on the data/loading path and not the empty state.
  • Drop the redundant per-branch ViewHeader in the dedicated zero-state branches of plans, projects, and teams views.
  • Remove the bottom border from the last .section in security-view.module.css so a single section shows no divider.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jun 1, 2026 5:08am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8270b281-b151-438c-9468-0d36185e0258

📥 Commits

Reviewing files that changed from the base of the PR and between a8f151d and 6abfd27.

📒 Files selected for processing (1)
  • web/sdk/react/views-new/pat/components/pat-created-dialog.tsx
✅ Files skipped from review due to trivial changes (1)
  • web/sdk/react/views-new/pat/components/pat-created-dialog.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Fixed view headers appearing in empty-state or restricted-access screens across Billing, Teams, Projects, Plans, Personal Access Tokens, and Service Accounts pages
    • Removed redundant headers from read-only/empty states for a cleaner UI
  • Style

    • Improved section visual separation by refining border rules
    • Minor UI polish for consistent icons and callout layout in relevant dialogs

Walkthrough

Multiple view components now render their ViewHeader only when showing content (not in empty or access-restricted states). Service accounts uses an inline ExclamationTriangleIcon for the restricted-access empty state, and security CSS removes the bottom border on the last section.

Changes

View Header and Empty State Refinements

Layer / File(s) Summary
ViewHeader conditional rendering across views
web/sdk/react/views-new/billing/billing-view.tsx, web/sdk/react/views-new/pat/pat-view.tsx, web/sdk/react/views-new/plans/plans-view.tsx, web/sdk/react/views-new/projects/projects-view.tsx, web/sdk/react/views-new/teams/teams-view.tsx, web/sdk/react/views-new/pat/components/pat-created-dialog.tsx
Headers are relocated into conditional branches so they appear only when content is available; small PAT dialog Callout JSX formatting updated as a supporting change.
Service accounts icon and header relocation
web/sdk/react/views-new/service-accounts/service-accounts-view.tsx
Restricted-access empty state icon switches from SVG Image asset to inline ExclamationTriangleIcon; "Service accounts" header moved into the table-rendering branch so it appears only with the data table.
Security view section border styling
web/sdk/react/views-new/security/security-view.module.css
CSS rule added to remove bottom border from the last .section element via :last-child selector.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • raystack/frontier#1566: Directly modifies projects-view.tsx empty-state rendering to adjust components shown in the no-projects branch.
  • raystack/frontier#1518: Introduced the BillingView ViewHeader structure that this PR refines by making rendering conditional.
  • raystack/frontier#1574: Updates service-accounts-view.tsx UI and icon/header rendering in the same areas modified here.

Suggested reviewers

  • rohilsurana
  • rsbh
  • paanSinghCoder
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title fix(sdk): hide ViewHeader on left-aligned zero states, security divider fix: IAM Design fixes Jun 1, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 1, 2026

Coverage Report for CI Build 26736345598

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 43.055%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37884
Covered Lines: 16311
Line Coverage: 43.06%
Coverage Strength: 12.07 hits per line

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty merged commit 0e8b178 into main Jun 1, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-iam-design branch June 1, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants