fix(admin): invoice amount filter units, org URL error, search focus#1676
fix(admin): invoice amount filter units, org URL error, search focus#1676rohanchkrabrty wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughPR updates organization administration views with three independent improvements: a helper to convert invoice amount filters from dollars to cents before server queries, corrected error messaging when organization URLs conflict during creation, and automatic focus on the organizations search field. ChangesOrganization Admin UI Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7fa59d45-ef1c-42a6-842a-c0326577ded3
📒 Files selected for processing (3)
web/sdk/admin/views/organizations/details/invoices/index.tsxweb/sdk/admin/views/organizations/list/create.tsxweb/sdk/admin/views/organizations/list/navbar.tsx
| showClearButton={true} | ||
| size="small" | ||
| onBlur={onSearchBlur} | ||
| autoFocus |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check DataTable.Search autoFocus usage patterns
# Find all DataTable.Search usages with autoFocus
rg -n -B3 -A3 'DataTable\.Search' --type=tsx --type=ts -g '!node_modules' | rg -C3 'autoFocus'Repository: raystack/frontier
Length of output: 89
Make autoFocus conditional for DataTable.Search
In web/sdk/admin/views/organizations/list/navbar.tsx (line 82), autoFocus will steal focus whenever the search input is shown on mount (when searchQuery is already set). Keep autoFocus for the explicit user action that opens search (e.g., clicking the search icon), and avoid focus stealing on initial render.
Coverage Report for CI Build 27007795918Coverage remained the same at 43.221%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
SearchOrganizationInvoicesRQL query — the backend stores amounts in cents, but the filter input was sending dollars, so number filters never matchedAlreadyExistserror now says "Organization URL is already taken" instead of "name already exists", matching the field's label ("Organization URL")