Skip to content

feat: update pat terminology#1721

Merged
rohanchkrabrty merged 3 commits into
mainfrom
feat-update-pat-terminology
Jun 30, 2026
Merged

feat: update pat terminology#1721
rohanchkrabrty merged 3 commits into
mainfrom
feat-update-pat-terminology

Conversation

@rohanchkrabrty

Copy link
Copy Markdown
Contributor

Summary

This PR updates views/pat to use correct terminology hook

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jun 30, 2026 11:48am

@rohanchkrabrty rohanchkrabrty self-assigned this Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • PAT pages now use product terminology to localize labels and helper text (including organization/project role labels, section headers, select option text, and multi-select placeholder).
  • Bug Fixes
    • Improved PAT form validation by applying create vs. update rules dynamically based on the current form state.
    • Updated validation messaging for selective project mode to use terminology-consistent, lower-case project wording.
  • Accessibility
    • Localized the “show more” chip accessibility label for project expand interactions.

Walkthrough

PAT form, details, and project chip components now derive organization and project labels from useTerminology. The form dialog also switches its Yup schema and selective-project validation message to terminology-driven text.

Changes

PAT Terminology Integration

Layer / File(s) Summary
Dynamic PAT form schema and labels
web/sdk/client/views/pat/components/pat-form-dialog.tsx
PATFormDialog now builds create and update Yup schemas from terminology, selects the active schema with useMemo, wires yupResolver to it, updates the selective-project validation message, and replaces static organization and project labels and placeholders with terminology-derived text.
Terminology-driven display text
web/sdk/client/views/pat/pat-details-view.tsx, web/sdk/client/views/pat/components/pat-project-chips.tsx
PATDetailsView and PATProjectChips now call useTerminology and use project or organization terminology for detail labels, the all-projects text, and the expanded-count aria-label.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • rsbh
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread web/sdk/client/views/pat/components/pat-form-dialog.tsx Outdated

@rohilsurana rohilsurana left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for terminology changes for project as well

@coveralls

coveralls commented Jun 30, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28441989338

Coverage remained the same at 43.819%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37096
Covered Lines: 16255
Line Coverage: 43.82%
Coverage Strength: 12.38 hits per line

💛 - Coveralls

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea2aa2c4-6a68-40ef-b756-0ea6b8154dfa

📥 Commits

Reviewing files that changed from the base of the PR and between acd9599 and 89de319.

📒 Files selected for processing (3)
  • web/sdk/client/views/pat/components/pat-form-dialog.tsx
  • web/sdk/client/views/pat/components/pat-project-chips.tsx
  • web/sdk/client/views/pat/pat-details-view.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/sdk/client/views/pat/components/pat-form-dialog.tsx

Comment thread web/sdk/client/views/pat/components/pat-project-chips.tsx
@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) June 30, 2026 11:56
@rohanchkrabrty rohanchkrabrty merged commit e829b65 into main Jun 30, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the feat-update-pat-terminology branch June 30, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants