Conversation
Contributor
StewartJingga
commented
Aug 28, 2021
StewartJingga
commented
- change metadata models to latest (https://github.com/odpf/proton/tree/main/odpf/assets)
- fix breaking changes from metadata models
- update columbus sink to allow mapping nested fields
StewartJingga
commented
Aug 28, 2021
| func (s *Sink) getDataMapper(data interface{}) func(interface{}) interface{} { | ||
| if s.cachedDataMapper == nil { | ||
| s.cachedDataMapper = s.buildDataMapper(data) | ||
| func (s *Sink) mapData(data interface{}) (interface{}, error) { |
Contributor
Author
There was a problem hiding this comment.
@ravisuhag We need this function to map fields (e.g. resource.urn to urn) so Columbus will accept the payload.
I gave myself a time to find a better approach but I could not orchestrate a better way to map these nested fields before sending to Columbus without making it overly complicated. I tried a few efforts using reflect library and it made it super complicated and without success.
So now I'm using the most easier approach just to get it working.
Member
There was a problem hiding this comment.
Works for now. Anyway, we are likely to change Columbus contract and there might be some changes in models as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.