Skip to content

Conversation

@sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Feb 18, 2022

Allows users to use secrets in assets and job configuration.
Exposes a different config .secret so that sensitive configuration are not printed in logs.

@coveralls
Copy link

coveralls commented Feb 18, 2022

Pull Request Test Coverage Report for Build 1922607126

  • 146 of 166 (87.95%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 72.71%

Changes Missing Coverage Covered Lines Changed/Added Lines %
run/service.go 2 8 25.0%
run/context.go 114 128 89.06%
Files with Coverage Reduction New Missed Lines %
run/context.go 9 64.93%
Totals Coverage Status
Change from base Build 1920645737: 0.03%
Covered Lines: 5222
Relevant Lines: 7182

💛 - Coveralls

Copy link
Contributor

@sravankorumilli sravankorumilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss over a call too, it is better to revisit this entirely, even after refactoring it is still hard to understand.

@sbchaos sbchaos linked an issue Feb 27, 2022 that may be closed by this pull request
2 tasks
@sbchaos sbchaos merged commit 76be7c4 into main Mar 3, 2022
@sbchaos sbchaos deleted the expose-different-secrets-config branch March 3, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secrets can be used through macros in the job specs.

4 participants