refactor: Use optimus config struct instead of interface

[deryrahman]

• remove config/interface.go
• remove config.Optimus getters

[coveralls]

Pull Request Test Coverage Report for Build 1897418940

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 72.399%

---

Totals
Change from base Build 1862408092:	0.0%
Covered Lines:	5115
Relevant Lines:	7065

---

💛 - Coveralls

[kushsharma]

Hi @deryrahman, although this looks good, can you please help me understand the reasoning behind why we are doing this?

[deryrahman]

Hi @kushsharma, As of now, since we only have 1 config implementation (which is config.Optimus) we don't need the interface. We also saw that the config is only data structure and have no behavior. And all the fields of conf.Optimus struct is exported (public) so we don't see the urgency of having getter. But if there's a strong reason to use getter, then we can discuss. cmiiw @sbchaos @sravankorumilli

[kushsharma]

Hi @kushsharma, As of now, since we only have 1 config implementation (which is config.Optimus) we don't need the interface. We also saw that the config is only data structure and have no behavior. And all the fields of conf.Optimus struct is exported (public) so we don't see the urgency of having getter. But if there's a strong reason to use getter, then we can discuss. cmiiw @sbchaos @sravankorumilli

Make sense, unless we have more than one implementation it is not needed as of now. The idea of having the interface was if we needed to inject a provider like etcd store or gcloud runtimevars for runtime changes but I agree that is unlikely in near future.