Skip to content

refactor: fix issues reported by stylecheck and enable the linter #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbchaos merged 6 commits into from
Mar 8, 2022
Merged

refactor: fix issues reported by stylecheck and enable the linter #193

sbchaos merged 6 commits into from
Mar 8, 2022

Conversation

@sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Feb 27, 2022

No description provided.

@sbchaos sbchaos linked an issue Feb 27, 2022 that may be closed by this pull request
Fix issues reported by linters and enable them #192
Closed
@coveralls
Copy link

coveralls commented Feb 27, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1950186779

  • 23 of 28 (82.14%) changed or added relevant lines in 5 files are covered.
  • 94 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 72.723%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ext/scheduler/airflow/airflow.go 4 5 80.0%
ext/datastore/bigquery/adapter.go 0 2 0.0%
ext/scheduler/airflow2/airflow.go 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
job/replay_syncer.go 13 85.06%
ext/datastore/bigquery/dataset_spec.go 15 64.66%
job/replay_manager.go 15 81.16%
ext/datastore/bigquery/table.go 24 85.08%
ext/datastore/bigquery/table_spec.go 27 64.66%
Totals Coverage Status
Change from base Build 1950086003: 0.0%
Covered Lines: 5159
Relevant Lines: 7094
💛 - Coveralls

@sbchaos sbchaos changed the title Fix issues reported by stylecheck and enable the linter refactor: fix issues reported by stylecheck and enable the linter Mar 4, 2022
@sbchaos
Merge branch 'main' into fix-stylecheck
3bcd025 
# Conflicts:
#	ext/scheduler/airflow2/airflow.go
@sbchaos sbchaos merged commit d775eb1 into main Mar 8, 2022
@sbchaos sbchaos deleted the fix-stylecheck branch March 8, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix issues reported by linters and enable them

4 participants

@sbchaos @coveralls @sravankorumilli