refactor: split config #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

deryrahman merged 54 commits into main from split-config

Apr 4, 2022

Member

deryrahman commented Mar 23, 2022 •

edited

Loading

implement LoadClientConfig
implement LoadServerConfig
refactor config load in the corresponding command
add config field validation using ozzo-validation
refactor config loader in main.go

deryrahman force-pushed the split-config branch from 86c2f81 to c2d95e5 Compare

March 24, 2022 09:39

deryrahman marked this pull request as ready for review

March 24, 2022 09:39

deryrahman linked an issue

that may be closed by this pull request

Split the config for server and client #170

Closed

coveralls commented Mar 24, 2022 •

edited

Loading

Pull Request Test Coverage Report for Build 2088475487

111 of 137 (81.02%) changed or added relevant lines in 6 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.07%) to 74.405%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
config/telemetry.go	0	1	0.0%
config/loader.go	64	69	92.75%
config/validation.go	40	49	81.63%
config/config_client.go	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
config/loader.go	1	92.68%
config/config.go	2	0%

Totals
Change from base Build 2088084344:	0.07%
Covered Lines:	5596
Relevant Lines:	7521

💛 - Coveralls

deryrahman assigned deryrahman and irainia

deryrahman requested review from sbchaos and sravankorumilli

March 25, 2022 01:52

sbchaos reviewed

View reviewed changes

config/build.go Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

config/config_server.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

main.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

main.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

config/config.go Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

config/loader.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

config/loader.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

cmd/commands.go Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

cmd/serve.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

config/validation.go Outdated Show resolved Hide resolved

deryrahman force-pushed the split-config branch from 61217f2 to 2630e74 Compare

March 28, 2022 06:09

irainia force-pushed the split-config branch from 2630e74 to 30fc6e7 Compare

March 28, 2022 07:58

deryrahman force-pushed the split-config branch from 30fc6e7 to ec125b3 Compare

March 29, 2022 04:35

This was referenced Mar 30, 2022

Feat register project namespace #257

Merged

feat: init project & namespace #256

Merged

sbchaos reviewed

View reviewed changes

cmd/serve.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

cmd/serve.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

cmd/serve.go Outdated Show resolved Hide resolved

sbchaos reviewed

View reviewed changes

cmd/serve.go Outdated Show resolved Hide resolved

sbchaos approved these changes

View reviewed changes

sravankorumilli reviewed

View reviewed changes

cmd/admin.go Show resolved Hide resolved

cmd/backup_create.go Outdated Show resolved Hide resolved

cmd/extension.go Outdated Show resolved Hide resolved

sravankorumilli requested changes

View reviewed changes

cmd/job_create.go Show resolved Hide resolved

cmd/resource.go Show resolved Hide resolved

cmd/secret.go Show resolved Hide resolved

cmd/version.go Show resolved Hide resolved

config/config_server.go Outdated Show resolved Hide resolved

config/loader.go Outdated Show resolved Hide resolved

config/validation.go Outdated Show resolved Hide resolved

deryrahman and others added 27 commits

April 4, 2022 14:54


          fix: build with BuildVersion

0a75bb1


          refactor: replay struct

a7084c1


          refactor: put comment legacy for the deprecated function

2d125c4


          fix: restore cli request fail

da6bda9


          refactor: pass global repo to relevant commands

9c10de3


          refactor: extract datastore initialization to a function

45a837f


          refactor: clean-up variable naming

29e3b98


          fix: use replay struct

940ef44


          fix: accpeting config file path on server command

0e0ce74


          refactor: clean up legacy loader

23b3137


          fix: remove server config load from home dir

380f361


          fix: linter

7c9869c


          add: gitignore for new configs

29a930e


          refactor: move setups in server package

1ef87aa


          refactor: logger & hplugin imported

d1963ef


          fix: type load config server

ae75900


          fix: missing --config flags

aadbf85


          fix: default scheduler in config server

1ed316c


          refactor: passing logger in extension command

46547b0


          fix: initialize pluginRegistry

ef05cec


          refactor: add TODO init paths config

d849fb3


          refactor: add TODO for validation

39b26d2


          fix: executable dir path

545f91f


          refactor: remove global env as a reasons when server is not reachable

e0f4a35


          docs: update config docs

bb6f797


          refactor: initialize dsRepo on backup create command

06df79e


          refactor: remove Validate func

14df505

deryrahman force-pushed the split-config branch from ebea6eb to 14df505 Compare

April 4, 2022 07:56

deryrahman merged commit eb9676a into main

deryrahman deleted the split-config branch

April 4, 2022 07:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet