Skip to content

refactor: fix gocritic diagnostic errors #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbchaos merged 5 commits into from
Mar 28, 2022
Merged

refactor: fix gocritic diagnostic errors #238

sbchaos merged 5 commits into from
Mar 28, 2022

Conversation

@sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Mar 23, 2022

No description provided.

@coveralls
Copy link

coveralls commented Mar 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2052579476

  • 18 of 24 (75.0%) changed or added relevant lines in 13 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 74.34%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/handler/v1beta1/adapter.go 0 1 0.0%
utils/file.go 0 1 0.0%
models/instance.go 2 4 50.0%
service/job_run_service.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
models/instance.go 1 10.0%
service/job_run_service.go 1 92.71%
Totals Coverage Status
Change from base Build 2052514227: 0.0%
Covered Lines: 5522
Relevant Lines: 7428
💛 - Coveralls

@sbchaos sbchaos merged commit e791078 into main Mar 28, 2022
@sbchaos sbchaos deleted the gocritic-diagnostic branch March 28, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbchaos @coveralls @sravankorumilli