Skip to content

feat: consume secrets from job config #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sravankorumilli merged 23 commits into from
Apr 11, 2022
Merged

feat: consume secrets from job config #259

sravankorumilli merged 23 commits into from
Apr 11, 2022

Conversation

@sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Apr 1, 2022

No description provided.

@coveralls
Copy link

coveralls commented Apr 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2141063090

  • 128 of 138 (92.75%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.82%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/job_run_service.go 10 11 90.91%
job/service.go 12 14 85.71%
api/handler/v1beta1/job_run.go 17 20 85.0%
service/plugin_service.go 65 69 94.2%
Totals Coverage Status
Change from base Build 2113898795: 0.2%
Covered Lines: 5937
Relevant Lines: 7935
💛 - Coveralls

@sbchaos sbchaos marked this pull request as ready for review April 6, 2022 09:39
@sravankorumilli sravankorumilli merged commit da4aa74 into main Apr 11, 2022
@sravankorumilli sravankorumilli deleted the plugin-configs branch April 11, 2022 12:42
@sbchaos sbchaos linked an issue Apr 12, 2022 that may be closed by this pull request
Executor should depend only on the secrets through JobSpec #224
Closed
@sravankorumilli sravankorumilli mentioned this pull request May 24, 2022
Closed
@sravankorumilli sravankorumilli added this to the Secret Management milestone May 24, 2022
@sbchaos sbchaos linked an issue May 24, 2022 that may be closed by this pull request
All Configs which includes secrets to be passed through JobSpec & Assets during Dependency Resolution #223
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Secret Management

4 participants

@sbchaos @coveralls @sravankorumilli