Skip to content

Sensor merge and leverage job run api in sensor logic #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siddhanta-rath merged 19 commits into from
Apr 11, 2022
Merged

Sensor merge and leverage job run api in sensor logic #278

siddhanta-rath merged 19 commits into from
Apr 11, 2022

Conversation

@Mryashbhardwaj
Copy link
Member

@Mryashbhardwaj Mryashbhardwaj commented Apr 8, 2022 •
edited by siddhanta-rath
Loading

closes #248

Mryashbhardwaj and others added 19 commits March 31, 2022 12:56
@Mryashbhardwaj
refactor: Leverage Job Run API in sensor
094ea79
@Mryashbhardwaj
fix: use UTC time format for query params of job_run api
86f77b2
@Mryashbhardwaj
fix: use UTC time format for query params of job_run api
5be7038
@Mryashbhardwaj
refactor: CrossTenantDependencySensor to use job_run api
3ceba72
@Mryashbhardwaj
refactor: merging CrossTenantDependencySensor SuperExternalTaskSensor
6a26481
@Mryashbhardwaj
Merge branch 'main' of https://github.com/odpf/optimus into merging_C…
1c9b88e 
…rossTenantDependencySensor_with_SuperExternalTaskSensor
@Mryashbhardwaj
test: replace SuperExternalTaskSensor with CrossTenantDependencySenso…
d85515c 
…r in expected_compiled_template
@Mryashbhardwaj
Merge branch 'main' of https://github.com/odpf/optimus into merging_C…
d65d215 
…rossTenantDependencySensor_with_SuperExternalTaskSensor
@Mryashbhardwaj
Merge branch 'main' of https://github.com/odpf/optimus
61332df
@Mryashbhardwaj
refactor: remove CrossTenantDependencySensor Dependence on SuperExter…
afe492a 
…nalTaskSensor
@Mryashbhardwaj
Merge pull request #1 from Mryashbhardwaj/merging_CrossTenantDependen…
f858483 
…cySensor_with_SuperExternalTaskSensor

Merging cross tenant dependency sensor with super external task sensor
@Mryashbhardwaj
refactor: merge CrossTenantDependencySensor with SuperExternalTaskSensor
174080d 
refactor: delete old SuperExternalTaskSensor logic
@Mryashbhardwaj
fix: addressing PR comments
9c78b7e
@Mryashbhardwaj
fix: SuperExternalTaskSensor
b3b8a56
@Mryashbhardwaj
fix: remomved commented code
c4d72c8
@Mryashbhardwaj
Merge branch 'main' of https://github.com/odpf/optimus into Sensor_me…
a621fca 
…rge_and_leverage_job_run_api
@siddhanta-rath
fix: revert to older version of salt
cec224c
@siddhanta-rath
test: fix failling testcase
e1dcb0e
@siddhanta-rath
test: sync loder test with main
2e80d21
@coveralls
Copy link

coveralls commented Apr 10, 2022

Pull Request Test Coverage Report for Build 2144927569

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 74.594%
Files with Coverage Reduction New Missed Lines %
config/loader.go 4 86.0%
Totals Coverage Status
Change from base Build 2113898795: -0.05%
Covered Lines: 5878
Relevant Lines: 7880
💛 - Coveralls

@siddhanta-rath siddhanta-rath merged commit d7aeb33 into main Apr 11, 2022
@siddhanta-rath siddhanta-rath deleted the Sensor_merge_and_leverage_job_run_api branch April 11, 2022 11:44
@siddhanta-rath siddhanta-rath mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Leverage Job Run API in sensor & remove the Job Status API

5 participants

@Mryashbhardwaj @coveralls @sravankorumilli @siddhanta-rath