feat: make job deployment asynchronous #296
Conversation
Pull Request Test Coverage Report for Build 2292221730
💛 - Coveralls |
job/deploy_manager.go
Outdated
| go m.spawnDeployer(m.deployer) | ||
| } | ||
|
|
||
| // wait until all workers are ready |
There was a problem hiding this comment.
we can use work group wait instead of us handling it explicitly.
There was a problem hiding this comment.
updated to use wait group.
| status VARCHAR(15) NOT NULL, | ||
| details JSONB, | ||
| created_at TIMESTAMP WITH TIME ZONE NOT NULL, | ||
| updated_at TIMESTAMP WITH TIME ZONE |
There was a problem hiding this comment.
Are we expecting this field to be nullable ?
There was a problem hiding this comment.
for the updated_at, yes, it can be null if it is just created.
There was a problem hiding this comment.
Was wondering as gorm has this field marked as not null
UpdatedAt time.Time `gorm:"not null" json:"updated_at"`
There was a problem hiding this comment.
oh just realized it. I can remove the not null from gorm.
There was a problem hiding this comment.
actually seeing from other tables, we are keeping UpdatedAt as NOT NULL, I think the value is filled with when the record is created initially. maybe I can change to follow this (having it as not null), what do you think? @sbchaos
There was a problem hiding this comment.
Sure, let's keep the field as not null as in other tables.
… job deploy status
…ssigner to able assign multiple workers in 1 iteration
|
@sravankorumilli @sbchaos please help to re-review this. have committed the changes based on what was discussed. thank you 🙂 |
…FirstExecutableRequest
Job deployment requested from Job Refresh is being done asynchronously by this PR.
#181