Skip to content

Conversation

@deryrahman
Copy link
Member

@deryrahman deryrahman commented Oct 19, 2022

Tracker:

@deryrahman deryrahman marked this pull request as draft October 19, 2022 09:01
@coveralls
Copy link

coveralls commented Oct 19, 2022

Pull Request Test Coverage Report for Build 3407765430

  • 22 of 34 (64.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 78.559%

Changes Missing Coverage Covered Lines Changed/Added Lines %
models/plugin.go 15 27 55.56%
Files with Coverage Reduction New Missed Lines %
models/plugin.go 1 54.7%
Totals Coverage Status
Change from base Build 3407345732: -0.08%
Covered Lines: 7980
Relevant Lines: 10158

💛 - Coveralls

@deryrahman deryrahman changed the base branch from main to climod-compile-asset-deprecation October 19, 2022 09:06
@deryrahman deryrahman force-pushed the clean-up-base-plugin branch from 47fe944 to e2aa6f2 Compare October 20, 2022 11:42
@deryrahman deryrahman marked this pull request as ready for review October 20, 2022 12:44
@deryrahman deryrahman requested a review from smarchone October 20, 2022 12:44
@deryrahman deryrahman self-assigned this Oct 20, 2022
@deryrahman deryrahman linked an issue Oct 21, 2022 that may be closed by this pull request
6 tasks
@deryrahman
Copy link
Member Author

Now, the flow of loading plugin will begin on reading yaml plugin first and then binary plugin, since the binary plugin require information eg. plugin name, from yaml.

Later on, we can do packaging the yaml+binary in one release, so that reading the plugin can be done in one shot. @smarch-int

return nil
}

type PluginOptions struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to discuss, if plugin options can also be depricated

@deryrahman deryrahman force-pushed the clean-up-base-plugin branch from e2aa6f2 to 7dc83b3 Compare October 31, 2022 04:00
@deryrahman deryrahman force-pushed the climod-compile-asset-deprecation branch from ea74b47 to 2b78e3f Compare October 31, 2022 05:51
@deryrahman deryrahman force-pushed the clean-up-base-plugin branch from 7dc83b3 to 88053e5 Compare October 31, 2022 06:53
@deryrahman deryrahman requested a review from smarchone November 4, 2022 01:53
Copy link
Member

@smarchone smarchone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from climod-compile-asset-deprecation to main November 7, 2022 03:34
@deryrahman deryrahman force-pushed the clean-up-base-plugin branch from 82057c1 to 5d2fa04 Compare November 7, 2022 04:28
@deryrahman deryrahman merged commit a113012 into main Nov 7, 2022
@deryrahman deryrahman deleted the clean-up-base-plugin branch November 7, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move CompileAssets from CommandLineMod interface to DepResMod

4 participants