-
Notifications
You must be signed in to change notification settings - Fork 154
refactor: remove BasePlugin mod #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 3407765430
💛 - Coveralls |
47fe944 to
e2aa6f2
Compare
|
Now, the flow of loading plugin will begin on reading yaml plugin first and then binary plugin, since the binary plugin require information eg. plugin name, from yaml. Later on, we can do packaging the yaml+binary in one release, so that reading the plugin can be done in one shot. @smarch-int |
| return nil | ||
| } | ||
|
|
||
| type PluginOptions struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to discuss, if plugin options can also be depricated
e2aa6f2 to
7dc83b3
Compare
ea74b47 to
2b78e3f
Compare
7dc83b3 to
88053e5
Compare
smarchone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
82057c1 to
5d2fa04
Compare
Tracker:
plugin/v1beta1